[202012] Check config file not empty after modify it in hostcfgd. #14385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nic-net#14115) What I did Check /etc/pam.d/sshd integrity after modify it in hostcfgd. Why I did it Found some incident that /etc/pam.d/sshd become empty file during OR upgrade. How I verified it Pass all UT. Add new UT to cover new code.
liuh-80
added
Request for 201811 Branch 
Request for 201911 Branch
and removed
Request for 201811 Branch
Request for 201911 Branch
labels
qiluo-msft
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Check /etc/pam.d/sshd integrity after modify it in hostcfgd.
Why I did it
Found some incident that /etc/pam.d/sshd become empty file during OR upgrade.
How I verified it
Pass all UT.
Add new UT to cover new code.
Details if related
This is a manually cherry-pick PR for sonic-net/sonic-host-services#36