Check config file not empty after modify it in hostcfgd. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jan 18, 2023
scripts/hostcfgd
Outdated
| @@ -781,11 +792,29 @@ class AaaCfg(object): | |||
| interface_ip = ipv4_addr | |||
| return interface_ip | |||
|
|
|||
|
|
|||
| def check_file_integrity(self, filename): | |||
There was a problem hiding this comment.
Strictly speaking, this file is only check file non-empty. If this is expected and good enough, please change the function name to narrow scope.
Otherwise, you may find some command line to verify the config. For example, sshd -T could be used to verify /etc/ssh/sshd_config. I am not sure if you can find the verification command for any other command. #Closed
There was a problem hiding this comment.
Fixed by change function name.
qiluo-msft
reviewed
Jan 18, 2023
scripts/hostcfgd
Outdated
| @@ -781,11 +792,29 @@ class AaaCfg(object): | |||
| interface_ip = ipv4_addr | |||
| return interface_ip | |||
|
|
|||
|
|
|||
| def check_file_integrity(self, filename): | |||
| rc, out = exec_cmd(cmd="du -b {}".format(filename), verbose=False) | |||
liuh-80
changed the title
qiluo-msft
reviewed
Jan 20, 2023
scripts/hostcfgd
Outdated
| syslog.syslog(syslog.LOG_ERR, "file size check failed: {} is missing".format(filename)) | ||
| return | ||
|
|
||
| # du command result is: 'size\tpath' |
qiluo-msft
approved these changes
Feb 2, 2023
|
Remove the [Request for 202205 branch] label, because for release <= 202205 need manually cherry-pick |
|
Manually cherry-pick PR created: sonic-net/sonic-buildimage#14115 |
This was referenced Mar 22, 2023
Merged
Open
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 27, 2023
…4385) **What I did** Check /etc/pam.d/sshd integrity after modify it in hostcfgd. **Why I did it** Found some incident that /etc/pam.d/sshd become empty file during OR upgrade. **How I verified it** Pass all UT. Add new UT to cover new code. **Details if related** This is a manually cherry-pick PR for sonic-net/sonic-host-services#36
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 20, 2023
**What I did** Check /etc/pam.d/sshd integrity after modify it in hostcfgd. **Why I did it** Found some incident that /etc/pam.d/sshd become empty file during OR upgrade. **How I verified it** Pass all UT. Add new UT to cover new code. **Details if related**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Check /etc/pam.d/sshd integrity after modify it in hostcfgd.
Why I did it
Found some incident that /etc/pam.d/sshd become empty file during OR upgrade.
How I verified it
Pass all UT.
Add new UT to cover new code.
Details if related