Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDDF debian package is not included in the build #10048

Closed
FuzailBrcm opened this issue Feb 21, 2022 · 6 comments
Closed

PDDF debian package is not included in the build #10048

FuzailBrcm opened this issue Feb 21, 2022 · 6 comments
Assignees
@xumia
Labels
Triaged this issue has been triaged

Comments

@FuzailBrcm
Copy link
Contributor

Description

PDDF debian package, sonic-platform-pddf_1.1_amd64.deb, is being built but its not present in the final binary sonic-broadcom.bin. Please check the below artefacts.

https://sonic-build.azurewebsites.net/ui/sonic/pipelines/138/builds/69143/artifacts/128581?branchName=master&artifactName=sonic-buildimage.broadcom

Interestingly, when I clone the sonic-buildimage repo and trigger a build, this debian package is part of the final binary sonic-broadcom.bin.

Steps to reproduce the issue:

  1. Pick any successful build from the official Broadcom builds. (https://sonic-build.azurewebsites.net/ui/sonic/pipelines/138/builds?branchName=master)
  2. Load it on any platform
  3. Run the following command,

dpkg -l |grep pddf
there is no package name listed.

Describe the results you received:

root@sonic:/home/admin# dpkg -l |grep pddf
root@sonic:/home/admin#

Describe the results you expected:

When I used the locally generated build, I see the following
root@sonic:/home/admin# dpkg -l |grep pddf
ii sonic-platform-pddf 1.1 amd64 kernel modules for platform devices such as psu, fan, sfp, led
root@sonic:/home/admin#

PDDF debian package should also be part of the official daily build from Azure Pipeline.

Output of show version:

root@sonic:/home/admin# show ver

SONiC Software Version: SONiC.master.69143-a0df35186
Distribution: Debian 11.2
Kernel: 5.10.0-8-2-amd64
Build commit: a0df35186
Build date: Mon Jan 31 20:31:35 UTC 2022
Built by: AzDevOps@sonic-build-workers-0014OR

Platform: x86_64-accton_as7326_56x-r0
HwSKU: Accton-AS7326-56X
ASIC: broadcom
ASIC Count: 1
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 11:07:31 up 2 min,  1 user,  load average: 0.75, 0.44, 0.18

Docker images:
REPOSITORY                    TAG                      IMAGE ID       SIZE
docker-dhcp-relay             latest                   a39125180204   447MB
docker-sonic-telemetry        latest                   94a4a9eab1f7   527MB
docker-sonic-telemetry        master.69143-a0df35186   94a4a9eab1f7   527MB
docker-orchagent              latest                   e06f7de29cb5   460MB
docker-orchagent              master.69143-a0df35186   e06f7de29cb5   460MB
docker-sflow                  latest                   ca1d9c4f56df   441MB
docker-sflow                  master.69143-a0df35186   ca1d9c4f56df   441MB
docker-teamd                  latest                   825eecf36d83   440MB
docker-teamd                  master.69143-a0df35186   825eecf36d83   440MB
docker-nat                    latest                   887387f5638e   443MB
docker-nat                    master.69143-a0df35186   887387f5638e   443MB
docker-fpm-frr                latest                   8e410e42a8fa   459MB
docker-fpm-frr                master.69143-a0df35186   8e410e42a8fa   459MB
docker-macsec                 latest                   26df02ee335c   443MB
docker-macsec                 master.69143-a0df35186   26df02ee335c   443MB
docker-sonic-mgmt-framework   latest                   67c2140af8c1   580MB
docker-sonic-mgmt-framework   master.69143-a0df35186   67c2140af8c1   580MB
docker-platform-monitor       latest                   95ede46894c4   539MB
docker-platform-monitor       master.69143-a0df35186   95ede46894c4   539MB
docker-snmp                   latest                   f4298a76b508   469MB
docker-snmp                   master.69143-a0df35186   f4298a76b508   469MB
docker-syncd-brcm             latest                   64c36db9528a   789MB
docker-syncd-brcm             master.69143-a0df35186   64c36db9528a   789MB
docker-mux                    latest                   536f5588a891   478MB
docker-mux                    master.69143-a0df35186   536f5588a891   478MB
docker-router-advertiser      latest                   499695387d3b   426MB
docker-router-advertiser      master.69143-a0df35186   499695387d3b   426MB
docker-gbsyncd-credo          latest                   0c51e7f0af4a   443MB
docker-gbsyncd-credo          master.69143-a0df35186   0c51e7f0af4a   443MB
docker-lldp                   latest                   b95721417bfe   466MB
docker-lldp                   master.69143-a0df35186   b95721417bfe   466MB
docker-database               latest                   6591d2fcbaff   426MB
docker-database               master.69143-a0df35186   6591d2fcbaff   426MB

root@sonic:/home/admin#

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@xumia xumia self-assigned this Feb 24, 2022
@xumia
Copy link
Collaborator

xumia commented Feb 24, 2022

Checked the logs, looks like the package was installed. Need some more time to check why lost in the bin image.
https://sonic-build.azurewebsites.net/api/sonic/artifacts?branchName=master&platform=broadcom&buildId=69143&target=target%2Fsonic-broadcom.bin.log

build_version: 'master.69143-a0df35186'
debian_version: '11.2'
kernel_version: '5.10.0-8-2-amd64'
asic_type: broadcom
commit_id: 'a0df35186'
branch: 'master'
release: 'none'
build_date: Mon Jan 31 18:59:29 UTC 2022
build_number: 69143
built_by: AzDevOps@sonic-build-workers-0014OR

+ sudo dpkg --root=./fsroot-broadcom -i target/debs/bullseye/sonic-platform-pddf_1.1_amd64.deb
Selecting previously unselected package sonic-platform-pddf.
(Reading database ... 43056 files and directories currently installed.)
Preparing to unpack .../sonic-platform-pddf_1.1_amd64.deb ...
Unpacking sonic-platform-pddf (1.1) ...
Setting up sonic-platform-pddf (1.1) ...

@xumia
Copy link
Collaborator

xumia commented Feb 24, 2022

It should be caused by the sonic-broadcom.bin built in the previous step. The last step to build the bin image skipped.

2022-01-31T22:12:12.4601478Z + '[' no == yes ']'
2022-01-31T22:12:12.4602798Z + make USERNAME=admin SONIC_BUILD_JOBS=4 SONIC_DPKG_CACHE_METHOD=wcache SONIC_DPKG_CACHE_SOURCE=/nfs/dpkg_cache/broadcom target/sonic-broadcom.bin
2022-01-31T22:12:12.4674219Z make: 'target/sonic-broadcom.bin' is up to date.
2022-01-31T22:12:12.9545755Z ##[section]Finishing: Build sonic image

@xumia
Copy link
Collaborator

xumia commented Feb 24, 2022

The bin image was built during building raw image, see https://sonic-build.azurewebsites.net/api/sonic/artifacts?branchName=master&platform=broadcom&buildId=69143&target=target%2Fsonic-broadcom.raw.log
We need to remove the bin image, before building it.

+ sed -i -e s/%%IMAGE_SHA1%%/76d34e1f841d0569fd767dce5a2ce19d1a14fd5f/ target/sonic-broadcom.bin
+ echo -n .
.+ cat /tmp/tmp.SyNWFUVtKb/sharch.tar
+ rm -rf /tmp/tmp.SyNWFUVtKb
+ echo  Done.
 Done.
+ echo Success:  Demo install image is ready in target/sonic-broadcom.bin:
Success:  Demo install image is ready in target/sonic-broadcom.bin:
+ ls -l target/sonic-broadcom.bin
-rw-r--r-- 1 AzDevOps gAzDevOps 1140348818 Jan 31 20:52 target/sonic-broadcom.bin

@xumia xumia mentioned this issue Feb 24, 2022
Closed
6 tasks
@FuzailBrcm
Copy link
Contributor Author

Thanks @xumia for a quick fix !

@xumia xumia mentioned this issue Feb 24, 2022
Merged
6 tasks
@xumia
Copy link
Collaborator

xumia commented Feb 25, 2022

@FuzailBrcm , could you please help review #10083?

@FuzailBrcm
Copy link
Contributor Author

@FuzailBrcm , could you please help review #10083?

Done

@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Mar 2, 2022
xumia added a commit that referenced this issue Mar 8, 2022
@xumia
[Build]: Fix the bin image generated from raw image issue (#10083)
f1d6d7c 
Why I did it
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
judyjoseph pushed a commit that referenced this issue Mar 20, 2022
@xumia @judyjoseph
[Build]: Fix the bin image generated from raw image issue (#10083)
8ba35d3 
Why I did it
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
xumia added a commit to xumia/sonic-buildimage-1 that referenced this issue Feb 6, 2023
@xumia
[Build]: Fix the bin image generated from raw image issue (sonic-net#…
24d7423 
…10083)

Why I did it
It is to fix the issue sonic-net#10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
@xumia xumia mentioned this issue Feb 6, 2023
Merged
8 tasks
qiluo-msft pushed a commit that referenced this issue Feb 9, 2023
@xumia
[Build]: Fix the bin image generated from raw image issue (#10083) (#…
f48734f 
…13672)

#### Why I did it
Cherry pick from #10083
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.

#### How I did it
Rename the intermediate file.
@xumia xumia closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xumia xumia

Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhangyanzhao @FuzailBrcm @xumia