[DX010 platform] fix dx010 platform testcase issues #13595
Conversation
qnos
force-pushed
the
dx010-platform-testcases-fix
branch
2 times, most recently
from
2aec6ef
to
d39ebd1
Compare
|
@qnos none of the fans are controllable on DX010? How is the platform then doing the thermal cooling as temperature warm up? |
DX010 take the automatic thermal control policy. It uses the thermal sensor temperature to automatically adjust the fan speed, and manually change the fan speed through fan API would be override by fancontrol daemon, so I set the fan to not controllable. |
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases
qnos
force-pushed
the
dx010-platform-testcases-fix
branch
from
d39ebd1
to
190c057
Compare
|
@prgeor please help unblock this merge, thanks |
@qnos I see your platform has the API to set the fan speed here Why skip this test to check the fan set_speed API? Can you adhere to this HLD |
@prgeor Yes, DX010 provide the set_speed API. But as I described, DX010 takes the automatic fan control policy. Only if we disable all fancontrol daemons in pmon, otherwise the speed value set through set_speed api would be overrided by fancontrol daemon, and cause the speed value from get api not match what we set. So I set the fans not controllable in platform.json. |
|
@lguohan please help merge |
|
@StormLiangMS @yxieca please cherry pick |
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases
|
Cherry-pick PR to 202205: #13778 |
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases Co-authored-by: Ikki Zhu <[email protected]>
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases
|
Cherry-pick PR to 202211: #13859 |
Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Why I did it
How I did it
Add corresponding configuration into chassis json file
How to verify it
Run platform tests cases to verify these failure cases
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)