-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] Use pull_request_target trigger instead to avoid codeQL check approval #12509
Merged
liushilongbuaa
merged 1 commit into
sonic-net:master
from
liushilongbuaa:fix-codeql-trigger
Oct 27, 2022
Merged
[action] Use pull_request_target trigger instead to avoid codeQL check approval #12509
liushilongbuaa
merged 1 commit into
sonic-net:master
from
liushilongbuaa:fix-codeql-trigger
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
approved these changes
Oct 27, 2022
Cherry-pick PR to 202205: #12527 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 27, 2022
mssonicbld
added a commit
that referenced
this pull request
Oct 27, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Cherry-pick PR to 202012: #12541 |
mssonicbld
added a commit
that referenced
this pull request
Nov 1, 2022
…k approval (#12509) (#12541) Co-authored-by: Liu Shilong <[email protected]>
mssonicbld
added
Included in 202012 Branch
and removed
Approved for 202012 Branch
Created PR to 202012 Branch
labels
Nov 1, 2022
richardyu-ms
pushed a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Now codeQL scanning needs approval for the first time a contributor creates a PR.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)