Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dualtor] Let T0 delay 10 seconds before sending BGP updates #12996

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Dec 8, 2022

Why I did it

To ensure, that after a BGP startup, dualtor T0 receives BGP updates before sending out BGP updates.
Please refer to sonic-net/SONiC#1161 for more details.

How I did it

add coalesce-time 10000 to the frr bgp startup config.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lolyu lolyu requested a review from lguohan as a code owner December 8, 2022 09:57
@yxieca
Copy link
Contributor

yxieca commented Dec 8, 2022

@lolyu looks like you need to fix more UTs.

@yxieca yxieca enabled auto-merge (squash) December 15, 2022 15:04
@yxieca yxieca merged commit d2ab55c into sonic-net:master Dec 15, 2022
@mssonicbld
Copy link
Collaborator

@lolyu PR conflicts with 202205 branch

@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@lguohan lguohan added the P0 Priority of the issue label Jan 18, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 3, 2023
…et#12996)

Why I did it
To ensure, that after a BGP startup, dualtor T0 receives BGP updates before sending out BGP updates.
Please refer to sonic-net/SONiC#1161 for more details.

How I did it
add coalesce-time 10000 to the frr bgp startup config.

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13632

mssonicbld pushed a commit that referenced this pull request Feb 4, 2023
Why I did it
To ensure, that after a BGP startup, dualtor T0 receives BGP updates before sending out BGP updates.
Please refer to sonic-net/SONiC#1161 for more details.

How I did it
add coalesce-time 10000 to the frr bgp startup config.

Signed-off-by: Longxiang Lyu <[email protected]>
yxieca pushed a commit that referenced this pull request Feb 8, 2023
Cherry-pick PR #12996 into 202012 branch.

Signed-off-by: Longxiang Lyu <[email protected]>
@liuh-80
Copy link
Contributor

liuh-80 commented Feb 8, 2023

Cherry-pick PR for 202012 merged: #13701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants