[Mellanox] Modified Platform API to support all firmware updates in single boot #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not have a return code.
|
Note: This is failing due to aforementioned dependencies. |
|
This pull request introduces 1 alert when merging 9fd75b5 into 3aec728 - view on LGTM.com new alerts:
|
liat-grozovik
changed the title
liat-grozovik
added
Platform: Mellanox
Request for 202111 Branch
|
This pull request introduces 1 alert when merging 07c6709 into 9dfdb43 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging dc436e9 into 4076194 - view on LGTM.com new alerts:
|
sujinmkang
approved these changes
Jan 24, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jan 31, 2022
…ingle boot (#9608) Why I did it Requirements from Microsoft for fwutil update all state that all firmwares which support this upgrade flow must support upgrade within a single boot cycle. This conflicted with a number of Mellanox upgrade flows which have been revised to safely meet this requirement. How I did it Added --no-power-cycle flags to SSD and ONIE firmware scripts Modified Platform API to call firmware upgrade flows with this new flag during fwutil update all Added a script to our reboot plugin to handle installing firmwares in the correct order with prior to reboot How to verify it Populate platform_components.json with firmware for CPLD / BIOS / ONIE / SSD Execute fwutil update all fw --boot cold CPLD will burn / ONIE and BIOS images will stage / SSD will schedule for reboot Reboot the switch SSD will install / CPLD will refresh / switch will power cycle into ONIE ONIE installer will upgrade ONIE and BIOS / switch will reboot back into SONiC In SONiC run fwutil show status to check that all firmware upgrades were successful
8 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 16, 2023
Partial cherry-pick of: [Mellanox] Modified Platform API to support all firmware updates in single boot #9608 - Why I did it To allow user manual reboot control over ONiE FW upgrade - How I did it Added a dedicated script argument handling - How to verify it mlnx-onie-fw-update.sh update --no-reboot Signed-off-by: Nazarii Hnydyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON sonic-net/sonic-platform-common#254 AND #9607 DO NOT MERGE WITHOUT
Why I did it
Requirements from Microsoft for
fwutil update allstate that all firmwares which support this upgrade flow must support upgrade within a single boot cycle. This conflicted with a number of Mellanox upgrade flows which have been revised to safely meet this requirement.How I did it
--no-power-cycleflags to SSD and ONIE firmware scriptsfwutil update allHow to verify it
platform_components.jsonwith firmware for CPLD / BIOS / ONIE / SSDfwutil update all fw --boot coldCPLD will burn / ONIE and BIOS images will stage / SSD will schedule for reboot
SSD will install / CPLD will refresh / switch will power cycle into ONIE
ONIE installer will upgrade ONIE and BIOS / switch will reboot back into SONiC
fwutil show statusto check that all firmware upgrades were successfulWhich release branch to backport (provide reason below if selected)
None
Description for the changelog
[mellanox] Modified Platform API to support all firmware updates in single boot
A picture of a cute animal (not mandatory but encouraged)