Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build]: Fix the bin image generated from raw image issue #10083

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Feb 24, 2022

Why I did it

It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.

How I did it

Rename the intermediate file.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia added the Build label Feb 24, 2022
Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@FuzailBrcm
Copy link
Contributor

@Kalimuthu-Velappan
Can you review these changes?

@xumia xumia changed the title [Build]: Fix the bin image generated from bin image issue [Build]: Fix the bin image generated from raw image issue Feb 25, 2022
@xumia xumia marked this pull request as ready for review February 25, 2022 02:49
@xumia xumia requested a review from lguohan as a code owner February 25, 2022 02:49
@xumia xumia requested a review from liushilongbuaa February 25, 2022 03:17
mkdir -p `dirname $OUTPUT_RAW_IMAGE`
sudo rm -f $OUTPUT_RAW_IMAGE

generate_device_list "./installer/$TARGET_PLATFORM/platforms_asic"

generate_onie_installer_image
generate_onie_installer_image "$tmp_output_onie_image"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good also applying to kvm.

@FuzailBrcm
Copy link
Contributor

/azpw run

@xumia xumia merged commit f1d6d7c into sonic-net:master Mar 8, 2022
@xumia xumia deleted the fix-pddf-no-install-1 branch March 8, 2022 13:15
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

judyjoseph pushed a commit that referenced this pull request Mar 20, 2022
Why I did it
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Feb 6, 2023
…10083)

Why I did it
It is to fix the issue sonic-net#10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.
@liuh-80
Copy link
Contributor

liuh-80 commented Feb 6, 2023

Cherry pick PR created: #13672

qiluo-msft pushed a commit that referenced this pull request Feb 9, 2023
…13672)

#### Why I did it
Cherry pick from #10083
It is to fix the issue #10048
When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one.

#### How I did it
Rename the intermediate file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants