[arp_update]: Set failed IPv6 neighbors to incomplete

[theasianpianist]

Signed-off-by: Lawrence Lee [email protected]

Why I did it

If IPv6 neighbor entries become "FAILED", then any subsequent neighbor advertisement messages will not be able to resolve these entries in the neighbor cache, only a ping or other traffic being sent from the device will be able to resolve these. This means that standby ToRs may have such FAILED entries stuck in the neighbor cache for a long time.

How I did it

After pinging any failed IPv6 neighbor entries, set the remaining failed/incomplete entries to a permanent INCOMPLETE state. This manual setting to INCOMPLETE prevents these entries from automatically transitioning to FAILED state, and since they are now incomplete any subsequent NA messages for these neighbors is able to resolve the entry in the cache.

How to verify it

1. Add a failed IPv6 neighbor entry to the neighbor cache (e.g. pinging an unreachable address)
2. Run the arp_update script
3. The entry should now be incomplete

root@str2-7050cx3-acs-08:/# ping fc02:1000::500
PING fc02:1000::500(fc02:1000::500) 56 data bytes
^C
--- fc02:1000::500 ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 13ms

root@str2-7050cx3-acs-08:/# ip neigh show fc02:1000::500
fc02:1000::500 dev Vlan1000  FAILED
root@str2-7050cx3-acs-08:/# arp_update
ping6: Warning: source address might be selected on device other than PortChannel101.
ping6: Warning: source address might be selected on device other than PortChannel102.
ping6: Warning: source address might be selected on device other than PortChannel103.
ping6: Warning: source address might be selected on device other than PortChannel104.
ping6: Warning: source address might be selected on device other than Vlan1000.
^C
root@str2-7050cx3-acs-08:/# ip neigh show fc02:1000::500
fc02:1000::500 dev Vlan1000  INCOMPLETE
root@str2-7050cx3-acs-08:/# sleep 10
root@str2-7050cx3-acs-08:/# ip neigh show fc02:1000::500
fc02:1000::500 dev Vlan1000  INCOMPLETE
root@str2-7050cx3-acs-08:/#

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[prsunny]

Can you please raise one for 202012?

[theasianpianist]

Can you please raise one for 202012?

Addressed offline, we should be able to cherry-pick to 202012 without any conflicts

[yejianquan]

/AzurePipelines run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).