[PATCH]: Update FRR patch 0009 to avoid inappropriate error messages #12912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Xu <[email protected]>
|
|
|
/easycla |
|
@theasianpianist can you please review this PR? It's same as #12754 that you reviewed and approved earlier, but the PR got closed and re-created here to get away with the CLA issue. Thanks |
yxieca
approved these changes
Dec 8, 2022
yxieca
added
Request for 202012 Branch
Request for 202111 Branch
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
…onic-net#12912) Why I did it As described in detail in sonic-net#12753, the current FRR patch 0009-ignore-route-from-default-table.patch is causing unwanted FRR/zebra error logs. This change gets rid of the error messages for routes from kernel default table while these routes are ignored in prefix encoding. How I did it This fix updates the original 0009 patch by checking if the routes are from table default before printing the error logs. The original patch checks the same condition and ignores the routes from table default in prefix encoding. How to verify it Follow the steps to repro as described in sonic-net#12753. Also verify the test case ipfwd/test_nhop_count.py no longer fails due to the error messages. Signed-off-by: Stephen Xu <[email protected]>
|
Cherry-pick PR to 202205: #13004 |
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Jan 18, 2023
…onic-net#12912) Why I did it As described in detail in sonic-net#12753, the current FRR patch 0009-ignore-route-from-default-table.patch is causing unwanted FRR/zebra error logs. This change gets rid of the error messages for routes from kernel default table while these routes are ignored in prefix encoding. How I did it This fix updates the original 0009 patch by checking if the routes are from table default before printing the error logs. The original patch checks the same condition and ignores the routes from table default in prefix encoding. How to verify it Follow the steps to repro as described in sonic-net#12753. Also verify the test case ipfwd/test_nhop_count.py no longer fails due to the error messages. Signed-off-by: Stephen Xu <[email protected]>
8 tasks
qiluo-msft
added
Included in 202012 Branch
Created PR to 202012 Branch
and removed
Included in 202012 Branch
labels
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 25, 2023
…12912) (#13423) …(#12912) Why I did it As described in detail in #12753, the current FRR patch 0009-ignore-route-from-default-table.patch is causing unwanted FRR/zebra error logs. This change gets rid of the error messages for routes from kernel default table while these routes are ignored in prefix encoding. How I did it This fix updates the original 0009 patch by checking if the routes are from table default before printing the error logs. The original patch checks the same condition and ignores the routes from table default in prefix encoding. How to verify it Follow the steps to repro as described in #12753. Also verify the test case ipfwd/test_nhop_count.py no longer fails due to the error messages. #### Why I did it Resolve cherry-pick conflict for #12912
|
202012 branch PR merged: #13423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #12753.
Why I did it
As described in detail in #12753, the current FRR patch
0009-ignore-route-from-default-table.patchis causing unwanted FRR/zebra error logs. This change gets rid of the error messages for routes from kernel default table while these routes are ignored in prefix encoding.How I did it
This fix updates the original 0009 patch by checking if the routes are from table default before printing the error logs. The original patch checks the same condition and ignores the routes from table default in prefix encoding.
How to verify it
Follow the steps to repro as described in #12753.
Also verify the test case
ipfwd/test_nhop_count.pyno longer fails due to the error messages.Which release branch to backport (provide reason below if selected)