Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] [Mellanox] Read transceiver EEPROM via sdk sysfs #12399

Merged

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Oct 14, 2022

This PR depends on #12531

Why I did it

  1. ethtool is not able to read certain pages(eg. page 11h) of CMIS cables.
  2. SDK provides a set of sysfs to expose the transceiver EEPROM, now we migrate from using ethtool to read these sysfs for transceiver EEPROM reading.

How I did it

  1. replace ethtool with accessing the SDK sysfs for cable EEPROM reading.
  2. Adjust the offset according to the SDK sysfs memory map.

How to verify it

run sonic-mgmt sfp-related regression test case.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2022

This pull request introduces 1 alert and fixes 6 when merging e7f964b into 479e6ea - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 5 for Unused local variable
  • 1 for Unreachable code

Signed-off-by: Kebo Liu <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request fixes 6 alerts when merging b02794b into bb2d098 - view on LGTM.com

fixed alerts:

  • 5 for Unused local variable
  • 1 for Unreachable code

@keboliu keboliu marked this pull request as ready for review October 17, 2022 12:25
@keboliu keboliu requested a review from prgeor October 20, 2022 03:51
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request fixes 6 alerts when merging 0d1a06c into 8e7a491 - view on LGTM.com

fixed alerts:

  • 5 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request fixes 6 alerts when merging 76f859f into 8e7a491 - view on LGTM.com

fixed alerts:

  • 5 for Unused local variable
  • 1 for Unreachable code

@keboliu
Copy link
Collaborator Author

keboliu commented Oct 21, 2022

Pending for new SDK upstream, please hold the merge first

@liat-grozovik liat-grozovik marked this pull request as draft October 25, 2022 15:17
@liat-grozovik
Copy link
Collaborator

Note: converted to draft as it is pending new SDK PR to be upstream first.

@liat-grozovik liat-grozovik marked this pull request as ready for review October 30, 2022 07:34
@liat-grozovik liat-grozovik merged commit 78043b8 into sonic-net:202012 Oct 30, 2022
@keboliu keboliu deleted the 202012_read_eeprom_via_sdk_sysfs branch November 13, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants