Skip to content

Commit

Permalink
revise the comments for function get_rx_los and get_tx_fault
Browse files Browse the repository at this point in the history
Signed-off-by: Kebo Liu <[email protected]>
  • Loading branch information
keboliu committed Oct 20, 2022
1 parent 0d1a06c commit 76f859f
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1307,8 +1307,13 @@ def get_rx_los(self):
Returns:
A Boolean, True if SFP has RX LOS, False if not.
Note : RX LOS status is latched until a call to get_rx_los or a reset.
Known issue in this function:
These bytes are protected from reading due to some limitation
in the future will provide a dedicated sysfs for rx_los reading
Currently only provide dummy implementation, always return false
"""
# Provide dummy implementation due to limitation, always return false

if not self.dom_supported:
return None

Expand All @@ -1335,8 +1340,13 @@ def get_tx_fault(self):
Returns:
A Boolean, True if SFP has TX fault, False if not
Note : TX fault status is lached until a call to get_tx_fault or a reset.
Known issue in this function:
These bytes are protected from reading due to some limitation
in the future will provide a dedicated sysfs for tx_fault reading
Currently only provide dummy implementation, always return false
"""
# Provide dummy implementation due to limitation, always return false

if not self.dom_supported:
return None

Expand Down

0 comments on commit 76f859f

Please sign in to comment.