Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save build timestamp to local tmp file at the start of build #2108

Closed
wants to merge 1 commit into from

Conversation

jipanyang
Copy link
Collaborator

Signed-off-by: Jipan Yang [email protected]

- What I did
To fix issue #2081

- How I did it
Save timestamp at the beginning of image build, and use the time stamp for all following module version.
- How to verify it

root@sonic:~# docker images
REPOSITORY                 TAG                                   IMAGE ID            CREATED             SIZE
docker-lldp-sv2            latest                                1d79abdadf07        49 minutes ago      332.9 MB
docker-lldp-sv2            warm-reboot.0-dirty-20181001.230229   1d79abdadf07        49 minutes ago      332.9 MB
docker-snmp-sv2            latest                                8689dc20bc23        49 minutes ago      373.4 MB
docker-snmp-sv2            warm-reboot.0-dirty-20181001.230229   8689dc20bc23        49 minutes ago      373.4 MB
docker-platform-monitor    latest                                746a266c43d7        52 minutes ago      336.2 MB
docker-platform-monitor    warm-reboot.0-dirty-20181001.230229   746a266c43d7        52 minutes ago      336.2 MB
docker-fpm-quagga          latest                                1859f6cd846f        52 minutes ago      389 MB
docker-fpm-quagga          warm-reboot.0-dirty-20181001.230229   1859f6cd846f        52 minutes ago      389 MB
docker-orchagent-brcm      warm-reboot.0-dirty-20181001.230229   e795108b9484        54 minutes ago      370.5 MB
docker-syncd-brcm          latest                                e7a4efbc84a0        56 minutes ago      411.7 MB
docker-syncd-brcm          warm-reboot.0-dirty-20181001.230229   e7a4efbc84a0        56 minutes ago      411.7 MB
docker-database            latest                                578f5d2d96ed        About an hour ago   298.5 MB
docker-database            warm-reboot.0-dirty-20181001.230229   578f5d2d96ed        About an hour ago   298.5 MB
docker-teamd               latest                                11a7f0b8ea65        About an hour ago   370.7 MB
docker-teamd               warm-reboot.0-dirty-20181001.230229   11a7f0b8ea65        About an hour ago   370.7 MB
docker-dhcp-relay          latest                                ded595fb1be5        About an hour ago   301.6 MB
docker-dhcp-relay          warm-reboot.0-dirty-20181001.230229   ded595fb1be5        About an hour ago   301.6 MB
docker-sonic-telemetry     latest                                44f029e11a68        About an hour ago   324.8 MB
docker-sonic-telemetry     warm-reboot.0-dirty-20181001.230229   44f029e11a68        About an hour ago   324.8 MB
docker-router-advertiser   latest                                b01d9e542317        About an hour ago   296.1 MB
docker-router-advertiser   warm-reboot.0-dirty-20181001.230229   b01d9e542317        About an hour ago   296.1 MB
root@sonic:~# show version
SONiC Software Version: SONiC.warm-reboot.0-dirty-20181001.230229
Distribution: Debian 9.5
Kernel: 4.9.0-7-amd64
Build commit: b22b992
Build date: Mon Oct  1 23:38:52 UTC 2018
Built by: jipan@sonicvm1

Docker images:
REPOSITORY                 TAG                                   IMAGE ID            SIZE
docker-lldp-sv2            latest                                1d79abdadf07        332.9 MB
docker-lldp-sv2            warm-reboot.0-dirty-20181001.230229   1d79abdadf07        332.9 MB
docker-snmp-sv2            latest                                8689dc20bc23        373.4 MB
docker-snmp-sv2            warm-reboot.0-dirty-20181001.230229   8689dc20bc23        373.4 MB
docker-platform-monitor    latest                                746a266c43d7        336.2 MB
docker-platform-monitor    warm-reboot.0-dirty-20181001.230229   746a266c43d7        336.2 MB
docker-fpm-quagga          latest                                1859f6cd846f        389 MB
docker-fpm-quagga          warm-reboot.0-dirty-20181001.230229   1859f6cd846f        389 MB
docker-orchagent-brcm      warm-reboot.0-dirty-20181001.230229   e795108b9484        370.5 MB
docker-syncd-brcm          latest                                e7a4efbc84a0        411.7 MB
docker-syncd-brcm          warm-reboot.0-dirty-20181001.230229   e7a4efbc84a0        411.7 MB
docker-database            latest                                578f5d2d96ed        298.5 MB
docker-database            warm-reboot.0-dirty-20181001.230229   578f5d2d96ed        298.5 MB
docker-teamd               latest                                11a7f0b8ea65        370.7 MB
docker-teamd               warm-reboot.0-dirty-20181001.230229   11a7f0b8ea65        370.7 MB
docker-dhcp-relay          latest                                ded595fb1be5        301.6 MB
docker-dhcp-relay          warm-reboot.0-dirty-20181001.230229   ded595fb1be5        301.6 MB
docker-sonic-telemetry     latest                                44f029e11a68        324.8 MB
docker-sonic-telemetry     warm-reboot.0-dirty-20181001.230229   44f029e11a68        324.8 MB
docker-router-advertiser   latest                                b01d9e542317        296.1 MB
docker-router-advertiser   warm-reboot.0-dirty-20181001.230229   b01d9e542317        296.1 MB

root@sonic:~#
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Oct 2, 2018

can we take similiar approach as BUILD_NUMBER and pass that variable into docker build instead of saving it on a temp file on the disk.

@lguohan
Copy link
Collaborator

lguohan commented Oct 5, 2018

addressed in #2118

@lguohan lguohan closed this Oct 6, 2018
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Dec 20, 2022
utilities:
* f0fc333e 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (sonic-net#2560) (HEAD -> 202012, github/202012) [Vaibhav Hemant Dixit]
* ad7a4d42 2022-11-30 | Support for platforms based on Clounix Networks' device (sonic-net#2108) [songqh2022]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Dec 22, 2022
utilities:
* f0fc333e 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (#2560) (HEAD -> 202012, github/202012) [Vaibhav Hemant Dixit]
* ad7a4d42 2022-11-30 | Support for platforms based on Clounix Networks' device (#2108) [songqh2022]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants