[Logs onboarding] Add select logs step #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2023
ogupte
changed the title
## Summary Fix elastic#155792 Bump `moment-timezone` from `0.5.34` to `0.5.43` (latest version) to include latest timezone changes ## Release Note Fix a bug causing the latest timezone changes to not be taken into account for date formatting (e.g Mexico 2023)
…lorerViewsClient (elastic#155878) ## 📓 Summary Depends on elastic#154900 Closes elastic#155112 This PR implements the `InventoryViewsService` and `InventoryViewsClient`, injecting an instance of the client in the KibanaContextForPlugin and exposing so a set of utilities to retrieve/update inventory views: - `findMetricsExplorerViews` - `getMetricsExplorerView` - `createMetricsExplorerView` - `updateMetricsExplorerView` - `deleteMetricsExplorerView` ## 👣 Next steps - Implement elastic#154725 to consume the service --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: Carlos Crespo <[email protected]>
…155866) ## Summary This PR wraps rendering of FieldPopover with additional try/catch and error boundary so we can look into exceptions if they happen.
…ic#155519) This PR adds e2e test run on real endpoint for coverage of isolate, processes, kill-process and suspend-process commands from respond console. Depends on elastic#155360
elastic#155113) ## Summary Part of elastic#147646 It passes the custom timerange to the converted Lens panel for both by ref and by value legacy visualizations. It works for all paths: - Edit visualization--> Edit in Lens--> Replace in dashboard - Convert to Lens --> Replace in dashboard  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Liberati <[email protected]>
Fixes the error
```
"script_stack": [
"[email protected]/org.elasticsearch.index.fielddata.ScriptDocValues.throwIfEmpty(ScriptDocValues.java:92)",
"[email protected]/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.get(ScriptDocValues.java:110)",
"[email protected]/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.getValue(ScriptDocValues.java:105)",
"""total = useCgroupLimit ? doc[limitKey].value : doc['system.memory.total'].value;
double """,
" ^---- HERE"
```
connected elastic/sdh-apm#765 (internal)
---------
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>
## Summary Closes elastic#155369 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
## Summary This PR adds a technical control to prevent incompatible mappings changes. These include: 1. Removing mapped fields. For the foreseeable future we require that teams only introduce new fields - in short: this avoids the "reindex" step in our migrations. 2. Changing the type of a field. We leverage ES to determine whether a given set of mappings can be applied "on top" of another. Similarly, this avoids the "reindex" step in migrations. The above checks depend on a snapshot of the mappings from `main`, these are the "current" mappings and are extracted from plugin code. This PR will bootstrap `main` with an initial set of mappings extracted from plugins (bulk of new lines added). ## The new CLI See the added `README.md` for details on how the CLI works. ## How will it work? Any new PR that introduces compatible mappings changes will result in a new snapshot being captured, then merged to main for other PRs to merge and run the same checks against (currently committing new snapshots happens in the CI check so there is no manual step of maintaining the snapshot). ## Additional We should consider combining this CI check with the existing check in `src/core/server/integration_tests/saved_objects/migrations/check_registered_types.test.ts`. Hopefully we can automate the check such that no manual review is needed from Core, not sure how we might cover the hash of the non-mappings related fields. We could consider narrowing the Jest test to exclude mappings. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: spalger <[email protected]>
…es should return to the documents view (elastic#152572) Closes elastic#152485 ~Would be better to override this somewhere in app state management logic but I could not find a right place for it.~ Done Current changes make sure that for text-based queries only grid view is possible (both on Discover and as embeddable) and the app state will be updated accordingly.
…eported issue (elastic#155938) Co-authored-by: Kibana Machine <[email protected]>
…ic#155942) This PR fixes a few integration tests that were failing because the ordering of the bulk creation of attachments isn't guaranteed. The solution is to compare the results ignoring ordering within the arrays. Fixes: elastic#154640 Flaky test runner results: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178 🟢
## Summary This PR adds a panel with 3 stages of ELSER trained model deployment: - Model is not deployed (with button to initiate deployment) - Model is deploying (polling status every 5 seconds) - Model has deployed Note that deploying the model does not start it; this will be implemented in a follow-up PR. The panel is discardable in the Pipelines screen but not discardable in the pipeline configuration flyout.
…abstraction (elastic#155342) ## Summary Abstract schema definitions for using Saved Objects with the content management api. For most schema types, this will reduce creation to only the attributes specific to a saved object. For Option types (create options, update options, search options) the saved object api is more complex and its likely that most SO types will only need to use a portion of it. In these cases we recommend using the provided schema definitions as a pattern for creating simpler schemas. Follow up to - elastic#154985 - expresses types in schema form --------- Co-authored-by: kibanamachine <[email protected]>
…nt_agent.js` CLI tool (elastic#155730) ## Summary As a follow up to PR elastic#155455 : - `run_endpoint_agent` CLI: Removed internal code that handles the creation of a VM and the enrollment of the agent with fleet and replaced it with use of methods now found in `endpoint_host_services` - created new service for managing agent download cache on local system - enhanced `run_endpoint_agent` to use cached version of agent download, and thus increase the performance of this tool
…56518) ## Summary Issues: elastic#155857 | elastic#156253 This PR fixed minimize amd maximize panel actions in Security Dashboard view. https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Pablo Machado <[email protected]>
…If No License (elastic#156296) ## Summary Remove some extra commas for the maintenance window no license prompt  Also, disable fetch if the user does not have the correct license type, this gets rid of the unnecessary error popover since the find maintenance window API will reject these requests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary This adds a beta badge and callout to the sync rules page for connec <img width="1009" alt="Screenshot 2023-05-03 at 16 08 58" src="https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png"> tors. <img width="1193" alt="Screenshot 2023-05-03 at 16 15 02" src="https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png">
## Summary This PR switches the ELSER model to the production one `.elser_model_1`. This has been manually tested with the Elasticsearch [8.8.0-SNAPSHOT Docker image from May 2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html). 
This PR: - Renames `CommentResponseRt` to `CommentRt` - Create `CommentUI` for the UI based on the snake to camel case version of `Comment` - Introduces a `AttachmentTransformedAttributes` type that should be used when returning `CommentAttributes` from the service layer
Co-authored-by: Kibana Machine <[email protected]>
## Summary issue: elastic#155034 | elastic#155586 Please find expected behaviours here: elastic#155034 (comment)
…splays expected fields (elastic#156435) ## Summary Fixes elastic#154009 This PR ensures the column field check for the data grid preview in DFA uses the Data view fields. BEFORE: <img width="1214" alt="image" src="https://user-images.githubusercontent.com/6446462/228678497-ffe65bf9-1b4c-4f56-bb3d-fe69ac941e62.png"> AFTER: <img width="1178" alt="image" src="https://user-images.githubusercontent.com/6446462/235797816-34425648-a470-4631-b6c2-ba453f62752d.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
…t, stop, reset) (elastic#156128) ## Summary Part of elastic#152009. This PR adds functional test for continuous transforms related actions including creation, start, stop, and reset. It also stablizes tests skipped in elastic#151889. Started [flaky test suite runner for continuous transform](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2185)... Started [flaky test suite runner for creation index pattern (previously skipped)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2187)... ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]>
## Summary Closes elastic#141526. This updates the function reference docs for Canvas expressions. The main update here is the deprecation message added to `filters` function. I'm also removing an expression example that doesn't work. <img width="866" alt="Screenshot 2023-05-02 at 9 26 54 AM" src="https://user-images.githubusercontent.com/1697105/235727031-8ece820e-3db5-42c7-ba11-e94d647a8b84.png"> @KOTungseth These changes impact as early as v8.4. Should I backport all the way back through 8.4? ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kaarina Tungseth <[email protected]>
## Summary This moves the Enterprise Search inputs for the bootstrap `<App>` to be explicit, rather than implicitly derived from what is and isn't excluded from a destructured object. Hopefully this will avoid us accidentally breaking the app because we changed the destructure or removed a variable somewhere.
…lastic#155915) ## Summary This PR fixes `Expected bounds` showing as a comparison option in the individual transaction page. Currently, it will show the bounds of the overall job, and not of the individual transaction, which is incorrect. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]>
…stic#156421) Resolves: elastic#155708 Currently we always trigger summary actions on custom interval even if there are no alerts to report. This PR changes this behaviour to skip summary actions when there are no alerts. ## To verify Create a Security Rule with a summary action that is on custom interval (`Summary of alerts` -> `Custom Frequency`) Add an alerts filter to filter out all the alerts (e.g. by using host name that doesn't exist) Expect the summary action not to be triggered.
…156571) ## Summary fetches a search application's indices' stats one at a time. if even one index is not available the stats api returns an error[^1]. while fetching them all together is probably more efficient we have to get them one-by-one just in case one isn't available. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios [^1]: <details><summary>stats errors response</summary> <pre> { "error": { "root_cause": [ { "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" } ], "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" }, "status": 404 } </pre> </details>
…lastic#156514) issue: elastic/security-team#6544 ## Summary ## Remove the `Technical Preview` label from the following UI pages - [x] (Must Do) Entity Analytics dashboard panels  - [x] (Must Do) Alert Flyout  - [x] All Hosts/ Users  - [x] Host/ User Details   - [x] Host/ Users Flyout  ## Retain the `Technical Preview` label in the following (No Changes): - [x] Enablement workflow from the EA dashboard - [x] Information message in flouts <img width="719" alt="image" src="https://user-images.githubusercontent.com/79533936/235903678-f982d483-7064-4172-ad1a-3a18b155c430.png">
… the test plan (elastic#156532) ## Summary This PR updates Maintenance Window callout tests to match the test plan. Maintenance Window callout is shown on the Rules Management page when there's a Maintenance Window running. <img width="1260" alt="233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259" src="https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png"> [**Test plan** (internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing ) [**Maintenance Window Callout issue**](elastic#155099) with more info about the feature
issue: elastic#156267 ## Summary Add a title to "Alerts Table inspect modal". **BEFORE** <img width="751" alt="Screenshot 2023-05-03 at 15 55 58" src="https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png"> **AFTER** <img width="769" alt="Screenshot 2023-05-03 at 15 58 30" src="https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png">
…6476) issue: elastic#155032 ## Summary Add a title to the "inspect model". **BEFORE** <img width="500" src="https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png"> **AFTER** <img width="500" src="https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png">
) **Resolves:** elastic#155596 ## Summary It fixes a broken header on small screen after adding rule snooze badge component. *Before:*    *After:*    ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
…lastic#156474) From the community forum: users can't access Discover on older browsers. ``` TypeError: t.at is not a function at http://xxx:5601/61109/bundles/plugin/data/kibana/data.plugin.js:1:312992 at Array.forEach () at n (http://xxx:5601/61109/bundles/plugin/data/kibana/data.plugin.js:1:312956) at s (http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10138) at http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10215 at Array.map () at a (http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:10207) at http://xxx:5601/61109/bundles/plugin/discover/kibana/discover.chunk.0.js:1:8442 at http://xxx:5601/61109/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:334:27724 at t.s._next (http://xxx:5601/61109/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:6:33456) ``` - https://discuss.elastic.co/t/update-to-8-7-0/329525 - https://discuss.elastic.co/t/elastic-8-7-0-error-in-discover-tab/332329/2 ## Summary This PR replaces `String` `.at` usage with `.charAt` so it does not require a polyfill for older browsers.
## Summary Closes elastic#156457 Closes elastic#156452 Closes elastic#156439 Closes elastic#156400 Closes elastic#156599 Closes elastic#156502 Closes elastic#156501 the resetPage function is creating this flakiness. I cant figure out why but is on the navigateToUrl function. Sometimes it reports #create and sometimes without the hash. The navigateToUrl is not needed as it is already done on another function. The only thing that is needed is the setTimePicker function. Flaky runer (100 times) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic#154941.
Depends on elastic#155961