[SecuritySolution] Update timeline actions #155692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
bug
angorayc
changed the title
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
angorayc
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Desk tested and LGTM!
✅ Legend action "Add to timeline" is consistent with the behavior, verified in overview page and alerts page
✅ Investigate in timeline is consistent with the behavior, verified on EA page
Observed that Add to timeline investigation is being used in hover actions, and Add to timeline is used in table cell actions, but they behaves the same, probably just wording
christineweng
approved these changes
May 3, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
## Summary issue: elastic#155034 | elastic#155586 Please find expected behaviours here: elastic#155034 (comment) (cherry picked from commit 5be0f40)
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[SecuritySolution] Update timeline actions (#155692)](#155692) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T17:03:48Z","message":"[SecuritySolution] Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue: #155034 |\r\nhttps://github.com//issues/155586\r\n\r\nPlease find expected behaviours here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","Feature:Lens Charts","v8.9.0"],"number":155692,"url":"https://github.com/elastic/kibana/pull/155692","mergeCommit":{"message":"[SecuritySolution] Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue: #155034 |\r\nhttps://github.com//issues/155586\r\n\r\nPlease find expected behaviours here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155692","number":155692,"mergeCommit":{"message":"[SecuritySolution] Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue: #155034 |\r\nhttps://github.com//issues/155586\r\n\r\nPlease find expected behaviours here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297"}}]}] BACKPORT--> Co-authored-by: Angela Chuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue: #155034 | #155586
Please find expected behaviours here: #155034 (comment)