Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Wrong action on Add to Timeline on Charts #155034

Closed
ghost opened this issue Apr 17, 2023 · 7 comments
Closed

[Security Solution]Wrong action on Add to Timeline on Charts #155034

ghost opened this issue Apr 17, 2023 · 7 comments
Assignees
@angorayc
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Milestone
8.8

Comments

@ghost
Copy link

ghost commented Apr 17, 2023

Describe the bug
Wrong action on Add to Timeline on Charts

Build Details:

Version: 8.8.0-SNAPSHOT
Commit: f150d0149c1a95923e1c9e2858ac8bdc4feec645
Build: 62260

Pre-conditions

  • Alert data should be present on the kibana instance

Steps

  • Navigate to Security Solution app.
  • Go to overview page and click on ... dots and observe the action Add to Timeline
  • Click on Add to Timeline
  • Expected Action : Respective Field : Value should be added in timeline but timeline should not open
  • Expected Action : Notification of same should pop-up
  • Currently "Add to timeline" action is behaving like "Investigate in timeline"

Note: This issue is occuring on all the charts been showing on the Security Solution App

Expected Result

  • Either the Action name should be Investigate in timeline instead of Add to Timeline
  • Or the Action of Add to Timeline need to be corrected

Screen-Cast

Overview.-.Kibana.Mozilla.Firefox.2023-04-17.18-00-48.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Apr 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc mentioned this issue Apr 25, 2023
Merged
@angorayc
Copy link
Contributor

angorayc commented Apr 26, 2023 •
edited
Loading

1. uiAction - addToNewTimeline (display as Investigate in timeline)

  • Clear the timeline before adding
  • Does not open timeline after adding
  • Show a success toast after adding successfully

Use case: Detection & response dashboards

Screenshot 2023-04-26 at 15 10 25

2. uiAction - addToTimeline (display as Add to timeline)

  • Does not clear the timeline before adding
  • Does not open the timeline
  • Show a success toast after adding successfully

Use case: Events cell action:

Screen.Recording.2023-04-26.at.15.14.20.mov

3. addToTimelineInvestigation (display as Add to timeline investigation)

  • Does not clear the timeline before adding
  • Show a success toast after adding successfully

Use case: timeline cell action

Screen.Recording.2023-04-26.at.15.19.28.mov

4. uiAction - addToTimeline (display as Add to timeline)

  • Does not clear the timeline before adding
  • Open the timeline after adding

Use case: Legend action:

Screen.Recording.2023-04-26.at.15.23.28.mov

5. display as Investigate in timeline

  • Clear the timeline before adding
  • Open timeline after adding

Use case: alerts / events row action

Screen.Recording.2023-04-26.at.15.44.45.mov

@angorayc
Copy link
Contributor

angorayc commented Apr 26, 2023 •
edited
Loading

@paulewing ,

Could you please decide the display name for the visualization's legend action? Should we clear the timeline before adding? Would we want to open the timeline or just show the success toast?

Should we define some clear naming and behaviours for all of our relevant use cases.

@angorayc
Copy link
Contributor

angorayc commented Apr 26, 2023 •
edited
Loading

Expected behaviour:

1.uiAction (cell) - addToNewTimeline (display as Investigate in timeline) -> could consider rename to investigateInNewTimeline
Clear the timeline before adding
Does not open timeline after adding -> Should open timeline after adding
Show a success toast after adding successfully -> Should remove the toast

4.uiAction (Lens) - addToTimeline (display as Add to timeline)
Does not clear the timeline before adding
Open the timeline after adding -> Does not open timeline after adding
Show a success toast after adding successfully

@stephmilovic stephmilovic mentioned this issue Apr 28, 2023
Closed
@angorayc angorayc added this to the 8.8 milestone May 3, 2023
@angorayc angorayc added the v8.8.0 label May 3, 2023
angorayc added a commit that referenced this issue May 3, 2023
@angorayc
[SecuritySolution] Update timeline actions (#155692)
5be0f40 
## Summary

issue: #155034 |
#155586

Please find expected behaviours here:
#155034 (comment)
@angorayc angorayc added the fixed label May 3, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 3, 2023
@angorayc
[SecuritySolution] Update timeline actions (elastic#155692)
9558f90 
## Summary

issue: elastic#155034 |
elastic#155586

Please find expected behaviours here:
elastic#155034 (comment)

(cherry picked from commit 5be0f40)
kibanamachine added a commit that referenced this issue May 3, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Update timeline actions (#155692) (#156595)
12884ac 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Update timeline actions
(#155692)](#155692)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T17:03:48Z","message":"[SecuritySolution]
Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue:
#155034
|\r\nhttps://github.com//issues/155586\r\n\r\nPlease find
expected behaviours
here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Lens
Charts","v8.9.0"],"number":155692,"url":"https://github.com/elastic/kibana/pull/155692","mergeCommit":{"message":"[SecuritySolution]
Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue:
#155034
|\r\nhttps://github.com//issues/155586\r\n\r\nPlease find
expected behaviours
here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155692","number":155692,"mergeCommit":{"message":"[SecuritySolution]
Update timeline actions (#155692)\n\n## Summary\r\n\r\nissue:
#155034
|\r\nhttps://github.com//issues/155586\r\n\r\nPlease find
expected behaviours
here:\r\nhttps://github.com//issues/155034#issuecomment-1523735414","sha":"5be0f40052b23d4699f41cd4e0189ffce6468297"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
@MadameSheema
Copy link
Member

@karanbirsingh-qasource please validate the fix on BC2. Thanks!

@stephmilovic stephmilovic added the Feature:Lens Charts Security Solution Lens Charts feature label May 4, 2023
@ghost
Copy link
Author

ghost commented May 4, 2023

Hi @MadameSheema

we have validated this issue on 8.8 BC2 and found the issue to be fixed ✔️ .

Build Details:

Version: 8.8 BC2
Commit:33efd47ee6927b54b328e901fe31d31eae875325
Build:62857

Screen-Cast:

Overview.-.Kibana.Mozilla.Firefox.2023-05-04.22-44-42.mp4
Alerts.-.Kibana.Mozilla.Firefox.2023-05-04.22-46-23.mp4
Hosts.-.Kibana.Mozilla.Firefox.2023-05-04.22-47-26.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed May 4, 2023
@ghost ghost added the QA:Validated Issue has been validated by QA label May 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Milestone
8.8
Development

No branches or pull requests
5 participants
@angorayc @stephmilovic @elasticmachine @MadameSheema @sukhwindersingh-qasource