Don't trigger summary actions when there are no alerts to report #156421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
added
release_note:fix
Team:ResponseOps
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
…stic#156421) Resolves: elastic#155708 Currently we always trigger summary actions on custom interval even if there are no alerts to report. This PR changes this behaviour to skip summary actions when there are no alerts. ## To verify Create a Security Rule with a summary action that is on custom interval (`Summary of alerts` -> `Custom Frequency`) Add an alerts filter to filter out all the alerts (e.g. by using host name that doesn't exist) Expect the summary action not to be triggered. (cherry picked from commit 506806f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
#156421) (#156617) # Backport This will backport the following commits from `main` to `8.8`: - [Don't trigger summary actions when there are no alerts to report (#156421)](#156421) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T19:15:01Z","message":"Don't trigger summary actions when there are no alerts to report (#156421)\n\nResolves: #155708\r\n\r\nCurrently we always trigger summary actions on custom interval even if\r\nthere are no alerts to report.\r\nThis PR changes this behaviour to skip summary actions when there are no\r\nalerts.\r\n\r\n## To verify\r\nCreate a Security Rule with a summary action that is on custom interval\r\n(`Summary of alerts` -> `Custom Frequency`)\r\nAdd an alerts filter to filter out all the alerts (e.g. by using host\r\nname that doesn't exist)\r\nExpect the summary action not to be triggered.","sha":"506806fee7f374205d98995a2754a0d296fbebb0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156421,"url":"https://github.com/elastic/kibana/pull/156421","mergeCommit":{"message":"Don't trigger summary actions when there are no alerts to report (#156421)\n\nResolves: #155708\r\n\r\nCurrently we always trigger summary actions on custom interval even if\r\nthere are no alerts to report.\r\nThis PR changes this behaviour to skip summary actions when there are no\r\nalerts.\r\n\r\n## To verify\r\nCreate a Security Rule with a summary action that is on custom interval\r\n(`Summary of alerts` -> `Custom Frequency`)\r\nAdd an alerts filter to filter out all the alerts (e.g. by using host\r\nname that doesn't exist)\r\nExpect the summary action not to be triggered.","sha":"506806fee7f374205d98995a2754a0d296fbebb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156421","number":156421,"mergeCommit":{"message":"Don't trigger summary actions when there are no alerts to report (#156421)\n\nResolves: #155708\r\n\r\nCurrently we always trigger summary actions on custom interval even if\r\nthere are no alerts to report.\r\nThis PR changes this behaviour to skip summary actions when there are no\r\nalerts.\r\n\r\n## To verify\r\nCreate a Security Rule with a summary action that is on custom interval\r\n(`Summary of alerts` -> `Custom Frequency`)\r\nAdd an alerts filter to filter out all the alerts (e.g. by using host\r\nname that doesn't exist)\r\nExpect the summary action not to be triggered.","sha":"506806fee7f374205d98995a2754a0d296fbebb0"}}]}] BACKPORT--> Co-authored-by: Ersin Erdal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #155708
Currently we always trigger summary actions on custom interval even if there are no alerts to report.
This PR changes this behaviour to skip summary actions when there are no alerts.
To verify
Create a Security Rule with a summary action that is on custom interval (
Summary of alerts->Custom Frequency)Add an alerts filter to filter out all the alerts (e.g. by using host name that doesn't exist)
Expect the summary action not to be triggered.