Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Security lens dashboard minimize and maximize action labels are swapped. #156253

Closed
machadoum opened this issue May 1, 2023 · 5 comments
Closed

[Security Solution] Security lens dashboard minimize and maximize action labels are swapped. #156253

machadoum opened this issue May 1, 2023 · 5 comments
Assignees
@angorayc
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Comments

@machadoum
Copy link
Member

machadoum commented May 1, 2023 •
edited
Loading

Describe the bug:
Security lens dashboard "minimize" and "maximize" action labels are swapped.

Build details:

VERSION: 8.8 BC1
BUILD: 62765
COMMIT: d0327fc75720e56ee76b640f07ffd1b154a348a8

Preconditions:

  1. 8.8 BC1 kibana cloud environment should be available.

Steps to reproduce:

  1. Navigate to a custom-created dashboard.
  2. Click on the three horizontal dots icon in the top right corner (lens options)
  3. Click on "more"
  4. The menu shows the "Maximize panel" option

Expected Result:
The menu should show "Minimize panel" because it is already maximized.

Screen Recording:
May-01-2023 13-46-05
@machadoum machadoum added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels May 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link

ghost commented May 1, 2023

#155857

@angorayc angorayc mentioned this issue May 3, 2023
Merged
1 task
angorayc added a commit that referenced this issue May 3, 2023
@angorayc @machadoum
[SecuritySolution] Fix minimize amd maximize panel actions (#156518)
c278f4e 
## Summary

Issues: #155857 |
#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.


https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov



### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 3, 2023
@angorayc
[SecuritySolution] Fix minimize amd maximize panel actions (elastic#1…
70eb80b 
…56518)

## Summary

Issues: elastic#155857 |
elastic#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.

https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <[email protected]>
(cherry picked from commit c278f4e)
kibanamachine added a commit that referenced this issue May 3, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Fix minimize amd maximize panel actions (#15…
f4620b2 
…6518) (#156570)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix minimize amd maximize panel actions
(#156518)](#156518)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T15:13:42Z","message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156518,"url":"https://github.com/elastic/kibana/pull/156518","mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156518","number":156518,"mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
@angorayc angorayc added the fixed label May 3, 2023
@stephmilovic stephmilovic added the Feature:Lens Charts Security Solution Lens Charts feature label May 4, 2023
@MadameSheema
Copy link
Member

@karanbirsingh-qasource @sukhwindersingh-qasource please validate the fix of this issue on current BC. Thanks!

@ghost
Copy link

ghost commented May 8, 2023

Hi @MadameSheema

we have closed this issue on the duplicate ticket id #155857 (comment)

Hence we are closing this ticket also.

thanks !!

@ghost ghost closed this as completed May 8, 2023
@ghost ghost added the QA:Validated Issue has been validated by QA label May 8, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@machadoum @angorayc @stephmilovic @elasticmachine @MadameSheema