Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix minimize amd maximize panel actions #156518

Merged
merged 3 commits into from
May 3, 2023
Merged

[SecuritySolution] Fix minimize amd maximize panel actions #156518

merged 3 commits into from
May 3, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 3, 2023 •
edited by kibanamachine
Loading

Summary

Issues: #155857 | #156253

This PR fixed minimize amd maximize panel actions in Security Dashboard view.

Screen.Recording.2023-05-03.at.13.01.26.mov

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels May 3, 2023
@angorayc angorayc self-assigned this May 3, 2023
@angorayc angorayc requested a review from a team as a code owner May 3, 2023 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

machadoum
machadoum approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/security_solution/public/dashboards/pages/details/index.test.tsx Outdated Show resolved Hide resolved
@angorayc angorayc enabled auto-merge (squash) May 3, 2023 13:03
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +347.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@angorayc angorayc merged commit c278f4e into elastic:main May 3, 2023
@kibanamachine kibanamachine mentioned this pull request May 3, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 3, 2023
@angorayc
[SecuritySolution] Fix minimize amd maximize panel actions (elastic#1…
70eb80b 
…56518)

## Summary

Issues: elastic#155857 |
elastic#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.

https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <[email protected]>
(cherry picked from commit c278f4e)
kibanamachine added a commit that referenced this pull request May 3, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Fix minimize amd maximize panel actions (#15…
f4620b2 
…6518) (#156570)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix minimize amd maximize panel actions
(#156518)](#156518)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T15:13:42Z","message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156518,"url":"https://github.com/elastic/kibana/pull/156518","mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156518","number":156518,"mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @machadoum