Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Maximize panel not working under dashboard view under security solution #155857

Closed
ghost opened this issue Apr 26, 2023 · 4 comments
Closed

[Security Solution]Maximize panel not working under dashboard view under security solution #155857

ghost opened this issue Apr 26, 2023 · 4 comments
Assignees
@angorayc
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security Dashboards Security solution custom dashboards feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0
Milestone
8.8

Comments

@ghost
Copy link

ghost commented Apr 26, 2023

Describe the bug
Maximize panel not working under dashboard view under security solution

Build Details:

Version:8.8.0-SNAPSHOT
Commit:f5034e60a501e7b61a3e1bff34e64c9b94c71344
Build:62546

Pre-conditions

  • Dashboard should be available on the kibana instance.
  • Note down the dashboard id of above dashboard

Steps

  • Navigate to Security Solution app.
  • Go to Dashboard page <kibana>app/security/dashboards
  • Paste the dashboard id in the end of above url
    e.g. <kibana>/app/security/dashboards/18aa6520-e420-11ed-a800-8bf24884859f
  • Click on three dot and then more options and click on Maximize panel
  • Observed that maximize is not working even same action is working on dashboard page under Analytics

Screen-cast

Dashboards.-.Kibana.Mozilla.Firefox.2023-04-26.16-29-19.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Apr 26, 2023
@ghost
Copy link
Author

ghost commented Apr 26, 2023

@sukhwindersingh-qasource please review

@ghost ghost mentioned this issue May 1, 2023
Closed
@MadameSheema MadameSheema removed their assignment May 2, 2023
@angorayc angorayc mentioned this issue May 3, 2023
Merged
1 task
@angorayc angorayc added this to the 8.8 milestone May 3, 2023
@angorayc angorayc added the v8.8.0 label May 3, 2023
angorayc added a commit that referenced this issue May 3, 2023
@angorayc @machadoum
[SecuritySolution] Fix minimize amd maximize panel actions (#156518)
c278f4e 
## Summary

Issues: #155857 |
#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.


https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov



### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 3, 2023
@angorayc
[SecuritySolution] Fix minimize amd maximize panel actions (elastic#1…
70eb80b 
…56518)

## Summary

Issues: elastic#155857 |
elastic#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.

https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <[email protected]>
(cherry picked from commit c278f4e)
kibanamachine added a commit that referenced this issue May 3, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Fix minimize amd maximize panel actions (#15…
f4620b2 
…6518) (#156570)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix minimize amd maximize panel actions
(#156518)](#156518)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T15:13:42Z","message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156518,"url":"https://github.com/elastic/kibana/pull/156518","mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156518","number":156518,"mergeCommit":{"message":"[SecuritySolution]
Fix minimize amd maximize panel actions (#156518)\n\n##
Summary\r\n\r\nIssues: #155857
|\r\nhttps://github.com//issues/156253\r\n\r\nThis PR
fixed minimize amd maximize panel actions in Security
Dashboard\r\nview.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado
<[email protected]>","sha":"c278f4e89469ada4d6a506752cd7182c03af69df"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
@angorayc angorayc added the fixed label May 3, 2023
@MadameSheema
Copy link
Member

@karanbirsingh-qasource please validate the issue on BC2. Thanks!

@stephmilovic stephmilovic added the Feature:Security Dashboards Security solution custom dashboards feature label May 4, 2023
@ghost
Copy link
Author

ghost commented May 4, 2023

Hi @MadameSheema

we have validated this issue on 8.8 BC2 and found the issue to be fixed now ✔️ . maximize and minimize are now working under security solution ✔️

Build Details:

Version: 8.8 BC2
Commit:33efd47ee6927b54b328e901fe31d31eae875325
Build:62857

Screen-Cast:

Dashboards.-.Kibana.Mozilla.Firefox.2023-05-04.22-13-57.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it .

thanks !!

@ghost ghost closed this as completed May 4, 2023
@ghost ghost added the QA:Validated Issue has been validated by QA label May 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Security Dashboards Security solution custom dashboards feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0
Projects
None yet
Milestone
8.8
Development

No branches or pull requests
5 participants
@angorayc @stephmilovic @elasticmachine @MadameSheema @sukhwindersingh-qasource