[Discover] Navigating from Field statistics tab to text based languages should return to the documents view

[jughosta]

Closes #152485
Would be better to override this somewhere in app state management logic but I could not find a right place for it. Done

Current changes make sure that for text-based queries only grid view is possible (both on Discover and as embeddable) and the app state will be updated accordingly.

[kertal]

@jughosta wanna iterate on that? you seem to have solved the issue in the embeddable, to solve in in the state, it should work like this:

kibana/src/plugins/discover/public/application/main/hooks/use_text_based_query_language.ts

Lines 110 to 114 in c486a16

	const nextState = {
	...(addDataViewToState && { index: dataViewObj.id }),
	...(addColumnsToState && { columns: nextColumns }),
	};

  const nextState = {
          ...(addDataViewToState && { index: dataViewObj.id }),
          ...(addColumnsToState && { columns: nextColumns }),
          ...(viewMode === VIEW_MODE.AGGREGATED_LEVEL && { viewMode: VIEW_MODE.DOCUMENT_LEVEL }),
        };

[jughosta]

@kertal Thanks! The suggestion works!

[kertal]

Great, glad I could help!

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kertal]

isPlainRecord would also be an option here

kibana/src/plugins/discover/public/application/main/utils/get_raw_record_type.ts

Line 29 in dec52ef

export function isPlainRecord(query?: Query | AggregateQuery): query is AggregateQuery {

[kertal]

Thx for brining this over the finishing line! 👍 Code LGTM
One last thing to consider, given a saved search is already persisted with the aggregated view , then we might take this into consideration when building the initial state

It could be done here

kibana/src/plugins/discover/public/application/main/utils/get_state_defaults.ts

Lines 83 to 86 in fba936c

	if (savedSearch.viewMode) {
	defaultState.viewMode = savedSearch.viewMode;
	}
	if (savedSearch.hideAggregatedPreview) {

Like this:

 if (savedSearch.viewMode && !isPlainRecord(query)) {
    defaultState.viewMode = savedSearch.viewMode;
  }

wdyt?

[kertal]

We might also consider to rename isPlainRecord ... or to create an alias function ... isTextBasedLanguage ... I always struggle to remember the plain name ... and I think, I was the one suggesting this name? 😄

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 8640f1c

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
discover	468	470	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	432.3KB	431.6KB	-679.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	28.0KB	28.0KB	+37.0B

Unknown metric groups

async chunk count

id	before	after	diff
discover	9	10	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	17	19	+2
securitySolution	399	402	+3
total			+5

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	18	20	+2
securitySolution	479	482	+3
total			+5

History

• 💚 Build #123479 succeeded 3c30304
• 💚 Build #111737 succeeded d40fc5b
• 💔 Build #111704 failed fdc56b5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

[jughosta]

@kertal Updated

Thanks for the feedback!

[kertal]

Thx for fixing it, adding tests and making the code prettier 🙇 Tested locally, works as expected. No more desperate people in SQL trying to leave field statistics!

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation