Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text based languages] Navigating from Field statistics tab to text based languages doesn't return to the documents view #152485

Closed
stratoula opened this issue Mar 1, 2023 · 1 comment · Fixed by #152572
Closed

[Text based languages] Navigating from Field statistics tab to text based languages doesn't return to the documents view #152485

stratoula opened this issue Mar 1, 2023 · 1 comment · Fixed by #152572
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@stratoula
Copy link
Contributor

stratoula commented Mar 1, 2023 •
edited
Loading

Kibana version:
main

Describe the bug:
I am on the dataview mode and I click on fields statistics. I select a text based language. I see the field statistics instead of the table view which is not correct as they are not supported.

discover

Expected behavior:
It should revert to the document view
@stratoula stratoula added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 1, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 1, 2023
@stratoula stratoula added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Mar 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 1, 2023
@davismcphee davismcphee added loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 1, 2023
@jughosta jughosta mentioned this issue Mar 2, 2023
Merged
@kertal kertal assigned kertal and jughosta and unassigned kertal Apr 25, 2023
jughosta added a commit that referenced this issue Apr 27, 2023
@jughosta
[Discover] Navigating from Field statistics tab to text based languag…
f528b34 
…es should return to the documents view (#152572)

Closes #152485
~Would be better to override this somewhere in app state management
logic but I could not find a right place for it.~ Done

Current changes make sure that for text-based queries only grid view is
possible (both on Discover and as embeddable) and the app state will be
updated accordingly.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 27, 2023
@jughosta
[Discover] Navigating from Field statistics tab to text based languag…
3ffd1f7 
…es should return to the documents view (elastic#152572)

Closes elastic#152485
~Would be better to override this somewhere in app state management
logic but I could not find a right place for it.~ Done

Current changes make sure that for text-based queries only grid view is
possible (both on Discover and as embeddable) and the app state will be
updated accordingly.

(cherry picked from commit f528b34)
kibanamachine referenced this issue Apr 27, 2023
@kibanamachine @jughosta
[8.8] [Discover] Navigating from Field statistics tab to text based l…
0011d05 
…anguages should return to the documents view (#152572) (#156010)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Discover] Navigating from Field statistics tab to text based
languages should return to the documents view
(#152572)](#152572)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T13:43:32Z","message":"[Discover]
Navigating from Field statistics tab to text based languages should
return to the documents view (#152572)\n\nCloses
https://github.com/elastic/kibana/issues/152485\r\n~Would be better to
override this somewhere in app state management\r\nlogic but I could not
find a right place for it.~ Done\r\n\r\nCurrent changes make sure that
for text-based queries only grid view is\r\npossible (both on Discover
and as embeddable) and the app state will be\r\nupdated
accordingly.","sha":"f528b34512171455a70c89c13d012feca4f67f61","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.9.0"],"number":152572,"url":"https://github.com/elastic/kibana/pull/152572","mergeCommit":{"message":"[Discover]
Navigating from Field statistics tab to text based languages should
return to the documents view (#152572)\n\nCloses
https://github.com/elastic/kibana/issues/152485\r\n~Would be better to
override this somewhere in app state management\r\nlogic but I could not
find a right place for it.~ Done\r\n\r\nCurrent changes make sure that
for text-based queries only grid view is\r\npossible (both on Discover
and as embeddable) and the app state will be\r\nupdated
accordingly.","sha":"f528b34512171455a70c89c13d012feca4f67f61"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152572","number":152572,"mergeCommit":{"message":"[Discover]
Navigating from Field statistics tab to text based languages should
return to the documents view (#152572)\n\nCloses
https://github.com/elastic/kibana/issues/152485\r\n~Would be better to
override this somewhere in app state management\r\nlogic but I could not
find a right place for it.~ Done\r\n\r\nCurrent changes make sure that
for text-based queries only grid view is\r\npossible (both on Discover
and as embeddable) and the app state will be\r\nupdated
accordingly.","sha":"f528b34512171455a70c89c13d012feca4f67f61"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
5 participants
@kertal @jughosta @elasticmachine @stratoula @davismcphee