Kibana doesn't warn the user about panels losing their drilldowns when users edit viz in lens and do save and return #147646
Comments
bhavyarm
added
bug
bhavyarm
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
stratoula
added
enhancement
|
I am changing this to enhancement because it needs some discussion. @elastic/kibana-presentation as you know, we allow the users to translate their legacy visualizations to Lens. These are replaced in the dashboard as by value visualizations. Can we somehow keep the drilldowns set? I don't want to add a warning because I want this to be an appealing path for the users. So I would like to explore first if there is a way to do the replacement but keep the drilldowns. |
stratoula
added
the
impact:low
|
I think it should be completely possible to retain drilldowns on panel type change. The only complexity I can think of with this is the potential for the new type of panel to not support all of the same triggers - but as far as I can tell that shouldn't happen, due to Lens and TSVB being mostly 1 to 1 in their functionality. @stratoula is that the case? If so, I think it's relatively low risk for us to just spread the enhancements on the embeddable even when changing types. |
|
Yes @ThomThomson this is correct, Lens supports more drilldowns than the legacy visualizations (the same + discover drilldown) so it is safe to also transfer them to the replaced embeddable. |
|
@ThomThomson the same applies for custom timerange, right? Does it require changes from your side too? |
|
You can see this in Ideally, all input that gets passed into the editor should be returned on |
|
@ThomThomson I could make the custom timerange to work for all cases expect from one When I have a saved TSVB visualization --> Edit in TSVB --> Edit in Lens --> Save and return At this point I dont have on the visualize editor the input for some reason. Here is the useEffect that I retrieve the embeddable input for the by ref visualizations https://github.com/elastic/kibana/blob/main/src/plugins/visualizations/public/visualize_app/components/visualize_editor.tsx#L76 Do you have a clue why I dont have this at this point? Here is my PR #155113 |
|
Looks like we don't provide the Wondering out loud - would it mess anything up on the Lens or TSVB side if we included the |
|
Do you have a PR that enables that Devon? If yes I can also do some tests. I dont think it will cause any problem tbh. |
|
I can open one that does that, sure! Edit - here's a draft PR |
|
Just noticed also tags are lost on Edit viz in Lens, when testing #155113 |
#155113) ## Summary Part of #147646 It passes the custom timerange to the converted Lens panel for both by ref and by value legacy visualizations. It works for all paths: - Edit visualization--> Edit in Lens--> Replace in dashboard - Convert to Lens --> Replace in dashboard  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Liberati <[email protected]>
elastic#155113) ## Summary Part of elastic#147646 It passes the custom timerange to the converted Lens panel for both by ref and by value legacy visualizations. It works for all paths: - Edit visualization--> Edit in Lens--> Replace in dashboard - Convert to Lens --> Replace in dashboard  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Liberati <[email protected]> (cherry picked from commit 61c82dc)
…d panel (#155113) (#155979) # Backport This will backport the following commits from `main` to `8.8`: - [[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)](#155113) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T09:11:35Z","message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Visualizations","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.8.0","v8.9.0"],"number":155113,"url":"https://github.com/elastic/kibana/pull/155113","mergeCommit":{"message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155113","number":155113,"mergeCommit":{"message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc"}}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
\r\n\r\n###){kind=link}
Kibana version: 8.6.0 BC7
Elasticsearch version: 8.6.0 BC7
Server OS version: darwin_x86_64
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: Lens doesn't display any message to user about their panels losing their drill-downs once user navigates to edit in lens from a panel and clicks save and return to dashboard.
Steps to reproduce:
Expected behavior: Kibana should tell the user about them losing drilldowns.
Panel with drilldowns:
Same panel in lens:
Panel back in dashboard with drilldowns missing:
The text was updated successfully, but these errors were encountered: