[Visualize2Lens] Transfers the custom timerange to the converted panel #155113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
release_note:enhancement
Feature:Visualizations
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
dej611
approved these changes
Apr 26, 2023
src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx
Outdated
Show resolved
Hide resolved
…nav_config.tsx Co-authored-by: Marco Liberati <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
stratoula
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
elastic#155113) ## Summary Part of elastic#147646 It passes the custom timerange to the converted Lens panel for both by ref and by value legacy visualizations. It works for all paths: - Edit visualization--> Edit in Lens--> Replace in dashboard - Convert to Lens --> Replace in dashboard  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Marco Liberati <[email protected]> (cherry picked from commit 61c82dc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 27, 2023
…d panel (#155113) (#155979) # Backport This will backport the following commits from `main` to `8.8`: - [[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)](#155113) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T09:11:35Z","message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Visualizations","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.8.0","v8.9.0"],"number":155113,"url":"https://github.com/elastic/kibana/pull/155113","mergeCommit":{"message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155113","number":155113,"mergeCommit":{"message":"[Visualize2Lens] Transfers the custom timerange to the converted panel (#155113)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/147646\r\n\r\nIt passes the custom timerange to the converted Lens panel for both by\r\nref and by value legacy visualizations.\r\nIt works for all paths:\r\n- Edit visualization--> Edit in Lens--> Replace in dashboard\r\n- Convert to Lens --> Replace in dashboard\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Liberati <[email protected]>","sha":"61c82dc8682edc33bc7a8483befed136052d95dc"}}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
\r\n\r\n###){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #147646
It passes the custom timerange to the converted Lens panel for both by ref and by value legacy visualizations.
It works for all paths:
Checklist