Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Change point detection fixes #156481

Merged
merged 4 commits into from
May 3, 2023
Merged

[ML] AIOps: Change point detection fixes #156481

merged 4 commits into from
May 3, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 3, 2023 •
edited
Loading

Summary

Closes #151592

  • Fixes auto refresh clearing the detailed change points view
  • Fix to display annotations at the edges of the chart

Checklist

@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0 labels May 3, 2023
@darnautov darnautov self-assigned this May 3, 2023
@darnautov darnautov requested a review from a team as a code owner May 3, 2023 08:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 792.2KB 792.4KB +244.0B
dataVisualizer 366.0KB 365.9KB -151.0B
ml 3.4MB 3.4MB -151.0B
transform 386.7KB 386.5KB -151.0B
total -209.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/ml-date-picker 12 11 -1
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +4

Total ESLint disabled count

id before after diff
@kbn/ml-date-picker 12 11 -1
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit a3fad62 into elastic:main May 3, 2023
@darnautov darnautov deleted the ml-151592-change-point-fixes branch May 3, 2023 16:31
@kibanamachine kibanamachine mentioned this pull request May 3, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 3, 2023
@darnautov
[ML] AIOps: Change point detection fixes (elastic#156481)
db42440 
(cherry picked from commit a3fad62)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 3, 2023
@kibanamachine @darnautov
[8.8] [ML] AIOps: Change point detection fixes (#156481) (#156591)
ec997b3 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] AIOps: Change point detection fixes
(#156481)](#156481)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T16:31:03Z","message":"[ML]
AIOps: Change point detection fixes
(#156481)","sha":"a3fad62c3491bd12c9cc8a62a126e21081422253","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","v8.8.0","v8.9.0"],"number":156481,"url":"https://github.com/elastic/kibana/pull/156481","mergeCommit":{"message":"[ML]
AIOps: Change point detection fixes
(#156481)","sha":"a3fad62c3491bd12c9cc8a62a126e21081422253"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156481","number":156481,"mergeCommit":{"message":"[ML]
AIOps: Change point detection fixes
(#156481)","sha":"a3fad62c3491bd12c9cc8a62a126e21081422253"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
@darnautov darnautov mentioned this pull request May 4, 2023
Closed
6 tasks
walterra
walterra reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra left review comments

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Change point detection enhancements
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @walterra @peteharverson