-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Create MetricsExplorerViewsService and MetricsExplorerViewsClient #155878
[Infrastructure UI] Create MetricsExplorerViewsService and MetricsExplorerViewsClient #155878
Conversation
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just tiny little thing.
x-pack/plugins/infra/public/services/metrics_explorer_views/metrics_explorer_views_client.ts
Outdated
Show resolved
Hide resolved
…trics_explorer_views_client.ts Co-authored-by: Carlos Crespo <[email protected]>
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
📓 Summary
Depends on #154900
Closes #155112
This PR implements the
InventoryViewsService
andInventoryViewsClient
, injecting an instance of the client in the KibanaContextForPlugin and exposing so a set of utilities to retrieve/update inventory views:findMetricsExplorerViews
getMetricsExplorerView
createMetricsExplorerView
updateMetricsExplorerView
deleteMetricsExplorerView
👣 Next steps