Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Case API Integration Tests.x-pack/test/cases_api_integration/security_and_spaces/tests/no_public_base_url/push·ts - cases security and spaces enabled: no_public_base_url push_case incident recorder server should format the comments correctly #154640

Closed
kibanamachine opened this issue Apr 10, 2023 · 5 comments · Fixed by #155942
Closed

Failing test: X-Pack Case API Integration Tests.x-pack/test/cases_api_integration/security_and_spaces/tests/no_public_base_url/push·ts - cases security and spaces enabled: no_public_base_url push_case incident recorder server should format the comments correctly #154640

kibanamachine opened this issue Apr 10, 2023 · 5 comments · Fixed by #155942
Assignees
@jonathan-buttner
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 10, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected 'Released host host-name with comment: comment text\n\nAdded by elastic.' to sort of equal 'Isolated host host-name with comment: comment text\n\nAdded by elastic.'
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Context.<anonymous> (push.ts:128:50)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16) {
  actual: 'Released host host-name with comment: comment text\n\nAdded by elastic.',
  expected: 'Isolated host host-name with comment: comment text\n\nAdded by elastic.',
  showDiff: true
}

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 10, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 10, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Apr 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 10, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Apr 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Apr 17, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 3925e93

kibanamachine added a commit that referenced this issue Apr 17, 2023
@kibanamachine
skip failing test suite (#154640)
3925e93
@jonathan-buttner jonathan-buttner self-assigned this Apr 26, 2023
@cnasikas cnasikas mentioned this issue Apr 27, 2023
Merged
jonathan-buttner added a commit that referenced this issue Apr 27, 2023
@jonathan-buttner
[Cases] Fixing a few more integration tests with arraysToEqual (#155942)
7000f0d 
This PR fixes a few integration tests that were failing because the
ordering of the bulk creation of attachments isn't guaranteed. The
solution is to compare the results ignoring ordering within the arrays.

Fixes: #154640

Flaky test runner results:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178
🟢
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 27, 2023
@jonathan-buttner
[Cases] Fixing a few more integration tests with arraysToEqual (elast…
db7da31 
…ic#155942)

This PR fixes a few integration tests that were failing because the
ordering of the bulk creation of attachments isn't guaranteed. The
solution is to compare the results ignoring ordering within the arrays.

Fixes: elastic#154640

Flaky test runner results:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178
🟢

(cherry picked from commit 7000f0d)
kibanamachine referenced this issue Apr 27, 2023
@kibanamachine @jonathan-buttner
[8.8] [Cases] Fixing a few more integration tests with arraysToEqual (#…
7f79254 
…155942) (#156034)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Fixing a few more integration tests with arraysToEqual
(#155942)](#155942)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jonathan
Buttner","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T15:13:30Z","message":"[Cases]
Fixing a few more integration tests with arraysToEqual (#155942)\n\nThis
PR fixes a few integration tests that were failing because
the\r\nordering of the bulk creation of attachments isn't guaranteed.
The\r\nsolution is to compare the results ignoring ordering within the
arrays.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/154640\r\n\r\nFlaky test runner
results:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178\r\n🟢","sha":"7000f0d38d8827327bf90b025008643d3c7208dd","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.8.0","v8.9.0"],"number":155942,"url":"https://github.com/elastic/kibana/pull/155942","mergeCommit":{"message":"[Cases]
Fixing a few more integration tests with arraysToEqual (#155942)\n\nThis
PR fixes a few integration tests that were failing because
the\r\nordering of the bulk creation of attachments isn't guaranteed.
The\r\nsolution is to compare the results ignoring ordering within the
arrays.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/154640\r\n\r\nFlaky test runner
results:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178\r\n🟢","sha":"7000f0d38d8827327bf90b025008643d3c7208dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155942","number":155942,"mergeCommit":{"message":"[Cases]
Fixing a few more integration tests with arraysToEqual (#155942)\n\nThis
PR fixes a few integration tests that were failing because
the\r\nordering of the bulk creation of attachments isn't guaranteed.
The\r\nsolution is to compare the results ignoring ordering within the
arrays.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/154640\r\n\r\nFlaky test runner
results:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2178\r\n🟢","sha":"7000f0d38d8827327bf90b025008643d3c7208dd"}}]}]
BACKPORT-->

Co-authored-by: Jonathan Buttner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-buttner jonathan-buttner

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Fixing a few more integration tests with arraysToEqual jonathan-buttner/kibana
5 participants
@jbudz @cnasikas @elasticmachine @kibanamachine @jonathan-buttner