adjusts timeout, only report 1 issue #156287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
Feature:Saved Objects
release_note:skip
|
@elasticmachine merge upstream |
pgayvallet
reviewed
May 2, 2023
| @@ -7,6 +7,7 @@ | |||
| */ | |||
|
|
|||
| module.exports = { | |||
| bail: true, // only report 1 issue | |||
There was a problem hiding this comment.
Yeah, I'm not sure about this.
Yes, when the test suite fails during setup, it avoid our GH notifications being flooded.
BUT it also means that in case of real failures (e.g when developing on the domain), we can't rely on the CI to list all the failures and we must run the suite(s) manually locally.
So... yeah, idk
There was a problem hiding this comment.
yea, I was testing different ways to resolve the failures.
@pgayvallet I've removed bail
TinaHeiligers
commented
May 2, 2023
src/core/server/integration_tests/saved_objects/migrations/group1/jest.integration.config.js
Outdated
Show resolved
Hide resolved
…up1/jest.integration.config.js
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #156244
Adjust timeout, only report one issue.