Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add beta badge to sync rules #156555

Merged
merged 2 commits into from
May 3, 2023
Merged

[Enterprise Search] Add beta badge to sync rules #156555

merged 2 commits into from
May 3, 2023

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented May 3, 2023 •
edited by kibanamachine
Loading

Summary

This adds a beta badge and callout to the sync rules page for connec
Screenshot 2023-05-03 at 16 08 58
tors.
Screenshot 2023-05-03 at 16 15 02

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0 labels May 3, 2023
@sphilipse sphilipse requested a review from a team May 3, 2023 14:17
@sphilipse sphilipse enabled auto-merge (squash) May 3, 2023 14:47
@JoseLuisGJ
Copy link
Contributor

Looks nice. Could we make the layout fixes as well? See details here:
https://github.com/elastic/enterprise-search-design/issues/97#issuecomment-1523535301

234607851-1429e94d-8dea-4110-8531-b01579696757

Draft fly out layout changes, bottom main actions as a common pattern, and Revert to active rules and Add sync rule buttons rearranged

@sphilipse sphilipse merged commit 30836a8 into elastic:main May 3, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / console app console context menu should copy as curl and show toast when copy as curl button is clicked

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2079 2081 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +825.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request May 3, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 3, 2023
@sphilipse
[Enterprise Search] Add beta badge to sync rules (elastic#156555)
e3dd1fa 
## Summary

This adds a beta badge and callout to the sync rules page for connec
<img width="1009" alt="Screenshot 2023-05-03 at 16 08 58"
src="https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png">
tors.
<img width="1193" alt="Screenshot 2023-05-03 at 16 15 02"
src="https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png">

(cherry picked from commit 30836a8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 3, 2023
@kibanamachine @sphilipse
[8.8] [Enterprise Search] Add beta badge to sync rules (#156555) (#15…
6d6c94a 
…6575)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Add beta badge to sync rules
(#156555)](#156555)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T15:41:39Z","message":"[Enterprise
Search] Add beta badge to sync rules (#156555)\n\n## Summary\r\n\r\nThis
adds a beta badge and callout to the sync rules page for connec\r\n<img
width=\"1009\" alt=\"Screenshot 2023-05-03 at 16 08
58\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png\">\r\ntors.\r\n<img
width=\"1193\" alt=\"Screenshot 2023-05-03 at 16 15
02\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png\">","sha":"30836a800ed510291200a736e4292aa8e4878f22","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156555,"url":"https://github.com/elastic/kibana/pull/156555","mergeCommit":{"message":"[Enterprise
Search] Add beta badge to sync rules (#156555)\n\n## Summary\r\n\r\nThis
adds a beta badge and callout to the sync rules page for connec\r\n<img
width=\"1009\" alt=\"Screenshot 2023-05-03 at 16 08
58\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png\">\r\ntors.\r\n<img
width=\"1193\" alt=\"Screenshot 2023-05-03 at 16 15
02\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png\">","sha":"30836a800ed510291200a736e4292aa8e4878f22"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156555","number":156555,"mergeCommit":{"message":"[Enterprise
Search] Add beta badge to sync rules (#156555)\n\n## Summary\r\n\r\nThis
adds a beta badge and callout to the sync rules page for connec\r\n<img
width=\"1009\" alt=\"Screenshot 2023-05-03 at 16 08
58\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943197-fecf2e11-daab-4c6a-a99e-cbf8b865f461.png\">\r\ntors.\r\n<img
width=\"1193\" alt=\"Screenshot 2023-05-03 at 16 15
02\"\r\nsrc=\"https://user-images.githubusercontent.com/94373878/235943190-e6d86a36-3e08-415c-8a29-bc886e1a9951.png\">","sha":"30836a800ed510291200a736e4292aa8e4878f22"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sphilipse @JoseLuisGJ @kibana-ci @kibanamachine @efegurkan