-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds ELSER config to the Trained Models UI #155867
Conversation
Pinging @elastic/ml-ui (:ml) |
Yes, it's intentional that ELSER can be deleted and reinstalled. This allows for repairs if it ever gets corrupted. If it's deployed then deletion should fail. (I assume it's not doing a force delete - we shouldn't make force delete easy at all as it has the potential to break search and ingest.) |
export const CURATED_MODEL_TAG = 'curated'; | ||
|
||
export const CURATED_MODEL_DEFINITIONS = { | ||
'.elser_model_1_SNAPSHOT': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _SNAPSHOT
will need to be removed in good time for release. Please set up a calendar reminder to do this. I will try to remember too, but the more people who are thinking about the need to update these places the better.
This checkbox is available for an undownloaded model, which I think shouldn't be the case. You can't delete a model that doesn't exist. |
I don't know if the download is just taking a very long time, but after deleting the model while it was downloading, a subsequent attempt to download has not changed from "downloading" for about 10mins |
x-pack/plugins/ml/public/application/services/ml_api_service/trained_models.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise UI text LGTM!
x-pack/plugins/ml/public/application/model_management/model_actions.tsx
Outdated
Show resolved
Hide resolved
…tions.tsx Co-authored-by: István Zoltán Szabó <[email protected]>
@jgowdyelastic fixed in b9cec9c |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @darnautov |
(cherry picked from commit bf64874)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.8`: - [[ML] ELSER config in the Trained Models UI (#155867)](#155867) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T06:16:17Z","message":"[ML] ELSER config in the Trained Models UI (#155867)","sha":"bf64874b4c789562acd1afda3bb76dbb2a01fd01","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:3rd Party Models","Team:ML","v8.8.0","v8.9.0"],"number":155867,"url":"https://github.com/elastic/kibana/pull/155867","mergeCommit":{"message":"[ML] ELSER config in the Trained Models UI (#155867)","sha":"bf64874b4c789562acd1afda3bb76dbb2a01fd01"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155867","number":155867,"mergeCommit":{"message":"[ML] ELSER config in the Trained Models UI (#155867)","sha":"bf64874b4c789562acd1afda3bb76dbb2a01fd01"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Summary
Elastic Learned Sparse EncodeR - or ELSER - is a representational model trained by Elastic that creates a sparse vector representation of a text. As a retrieval model, ELSER performs text-expansion for more relevant search results with expanding a passage to a sparse representation of tokens that are carefully chosen to improve a semantically relevant retrieval.
This PR adds a hardcoded ELSER config into the ML trained models list in order to allow downloading of the model.
Checklist