[Serverless] Unskip CLI flag test #155998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
afharo
added
the
failed-test
afharo
commented
Apr 27, 2023
Comment on lines
+128
to
+130
| if (!existsSync(path)) { | ||
| writeMode(projectType === true ? 'es' : projectType); | ||
| } else if (typeof projectType === 'string') { |
There was a problem hiding this comment.
We only created new files when --serverless was called without a project type. It should be fixed now 😅
|
Pinging @elastic/kibana-core (Team:Core) |
lukeelmers
approved these changes
Apr 27, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @afharo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We only created new files when --serverless was called without a project type. This PR fixes that. It also refactors the handling and killing of the child process so that it doesn't leak from one test to another.
For maintainers