Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Missing Chart name in Inspect Modal Title #155032

Closed
ghost opened this issue Apr 17, 2023 · 5 comments
Closed

[Security Solution]Missing Chart name in Inspect Modal Title #155032

ghost opened this issue Apr 17, 2023 · 5 comments
Assignees
@machadoum
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@ghost
Copy link

ghost commented Apr 17, 2023

Describe the bug
Missing Chart name in Inspect Modal Title

Build Details:

Version: 8.8.0-SNAPSHOT
Commit: f150d0149c1a95923e1c9e2858ac8bdc4feec645
Build: 62260

Pre-conditions

  • Alert data should be present on the kibana instance

Steps

  • Navigate to Security Solution app.
  • Go to Overview dashboard
  • Click on three Dots then options
  • Click on inspect
  • Observed that Missing "Alert Trend" text in inspect modal title

Expected Result

  • 8.7.1 BC
working.mp4

Screen-Cast

not-working.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Apr 17, 2023
@ghost
Copy link
Author

ghost commented Apr 17, 2023

@sukhwindersingh-qasource please review

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Apr 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@stephmilovic stephmilovic removed their assignment Apr 24, 2023
@stephmilovic stephmilovic mentioned this issue May 1, 2023
Closed
@stephmilovic stephmilovic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels May 1, 2023
@machadoum machadoum mentioned this issue May 3, 2023
Merged
machadoum added a commit that referenced this issue May 4, 2023
@machadoum
Fix missing Chart name in Alert Trend Inspect Modal Title (#156476)
0974e59 
issue: #155032

## Summary

Add a title to the "inspect model".


**BEFORE**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png">

**AFTER**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 4, 2023
@machadoum
Fix missing Chart name in Alert Trend Inspect Modal Title (elastic#15…
97ca209 
…6476)

issue: elastic#155032

## Summary

Add a title to the "inspect model".

**BEFORE**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png">

**AFTER**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png">

(cherry picked from commit 0974e59)
kibanamachine referenced this issue May 4, 2023
@kibanamachine @machadoum
[8.8] Fix missing Chart name in Alert Trend Inspect Modal Title (#156476
c559077 
) (#156647)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix missing Chart name in Alert Trend Inspect Modal Title
(#156476)](#156476)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-04T08:09:26Z","message":"Fix
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
https://github.com/elastic/kibana/issues/155032\r\n\r\n##
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156476,"url":"https://github.com/elastic/kibana/pull/156476","mergeCommit":{"message":"Fix
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
https://github.com/elastic/kibana/issues/155032\r\n\r\n##
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156476","number":156476,"mergeCommit":{"message":"Fix
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
https://github.com/elastic/kibana/issues/155032\r\n\r\n##
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <[email protected]>
@stephmilovic stephmilovic added the Feature:Lens Charts Security Solution Lens Charts feature label May 4, 2023
@machadoum machadoum added the fixed label May 5, 2023
@MadameSheema
Copy link
Member

@karanbirsingh-qasource please validate the fix of this issue on BC3. Thanks!

@ghost
Copy link
Author

ghost commented May 11, 2023

Hi @MadameSheema

we have validated this issue on 8.8 Bc3 and found the issue to be fixed ✔️ .

Build Details:

Version: 8.8 BC3
Commit:85b22d307ab93fca95c1698ede4cb61d85f3d314
Build:62994

Snap-Shot:

image

Hence we are Closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed May 11, 2023
@ghost ghost added the QA:Validated Issue has been validated by QA label May 11, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@machadoum @stephmilovic @elasticmachine @MadameSheema @sukhwindersingh-qasource