Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #22039

Merged
merged 103 commits into from
Nov 24, 2023
Merged

test #22039

merged 103 commits into from
Nov 24, 2023

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 23, 2023

No description provided.

brad-decker and others added 30 commits October 31, 2023 09:04
@brad-decker @HowardBraham
dev(chore): log test names and suites (#21570)
c3f6e17 
## **Description**
Before #21441 the test reporter would output the test path it was
executing which made figuring out where tests were failing at fairly
easy. The updates in #21441 make tests run faster but it doesn't help
when trying to ascertain where failures occur. To make it slightly
easier this PR adds some reporting to the run-all script and the
withFixtures and verboseReportOnFailure functions to explicitly call out
where breakdowns happen.

This PR also changes from using `this.test.title` to
`this.test.fullTitle()` which includes the name spacing of Describe
Blocks for easier access.

## **Related issues**


## **Manual testing steps**

1. View CircleCI output on develop for any of the E2E tests.
2. Observe that the test steps are written out verbosely, but no
information about what file or test is being ran.
3. Do the same on this branch's CircleCI output and see the the test
files and names are logged.
4. Repeat steps locally on develop and this branch to see local terminal
console outputs file paths and test names.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="1271" alt="Screenshot 2023-10-26 at 1 48 27 PM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/9dae6c6c-9c6b-4fc6-8852-c02ae7662c65">

### **After**
<img width="1249" alt="Screenshot 2023-10-26 at 2 15 21 PM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/fa6058f9-31b5-4dc7-b0fc-d9a76ca92cb8">
<img width="1197" alt="Screenshot 2023-10-26 at 2 15 41 PM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/c5be627a-34fe-4e70-af1a-b478b0d06b4a">

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Howard Braham <[email protected]>
@seaona
test: disable it failing block for ppom malicious signature (#21627)
dec3b18 
Disabling e2e test for malicious signatures, until fixed
@FrederikBolding
Fix snaps website link pointing to the wrong URL (#21619)
51dbd52 
Fixes the snaps website link pointing to the wrong URL.

Testing steps:
1. Install https://snaps.metamask.io/snap/npm/tezos-metamask-snap/
2. Click website link in snap settings
3. See that you are navigated to https://metamask.tezos.com/
@darkwing
UX: Multichain: Send Flow: Recipient: Address Book (#21530)
d9bada9 
## **Description**

This PR brings the address book and contact + recent transactions search
to the recipient input.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#1562

## **Manual testing steps**

### 1.  "Contacts"
1.  Click any "Contacts" item
2. See the contact populated in the "To" field

### 2. "Contacts Search"
1.  Search for a contact that lives in your address book
2. See that contact narrowed down in the contacts list

### 3.  Domain Resolution / "Confusable"
1.  In the "To" field, type `metamask.eth`
2. See on item display under "To", and it's the `metamask.eth` item with
red `m`'s (`Confusable` component)

## **Screenshots/Recordings**

### **Before**

(Wasn't there)

### **After**


https://github.com/MetaMask/metamask-extension/assets/46655/cfcca367-4e52-4af9-a243-3d84cdaaed69

Note: I know that the Address Book item doesn't look the same as the
Your Accounts item -- that will be fixed in
MetaMask/MetaMask-planning#1566

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@HowardBraham
e2e: add Snap Accounts ethSign test, convert to TypeScript, optimize (#…
74a7ab5 
…21480)

Continuing to follow this E2E development plan
https://www.notion.so/Snaps-Keyring-V1-290f59e37414470d97030e5dc22ab36d

### Important Features
- The Eth Sign tests have been added
- The whole `test/e2e/accounts` folder is now in TypeScript. As far as I
can tell, this creates Extension's first TypeScript E2E tests. (This was
not an easy task, because there was no prior work to follow, and I hit a
bunch of type and import hurdles along the way.) To support this:
  - Updated `mocha` to the newest `10.2.0`
  - Added `@types/mocha` and `@types/selenium-webdriver`
- Required some changes in `test/e2e/webdriver/driver.js`, most notably
how the `PAGES` object works
- JSDoc in some JS files to get better type hints when there's no
TypeScript
- `test-snap-accounts.spec.js` was previously the longest-runtime E2E
testfile, often taking 18-25 minutes all by itself, and being the
bottleneck. I split and optimized the tests, so now the longest-runtime
testfile is `snap-account-signatures.spec.ts` at 4 minutes.
- Stabilized a bunch of E2E tests using these techniques:
  - No more `findElement` then `assert(getText())` pattern
  - Safer window waiting and switching
  - Using `clickElementSafe` for scroll buttons
- Made `test-e2e-chrome-multichain` required for `all-tests-pass` again.
I did not actually fix the E2E tests that were failing, I just added
this code to another spot in `snap-accounts-transfers.spec.ts`. I'm not
sure that actually fixing it is possible right now.
```
// TODO: Update Test when Multichain Send Flow is added
if (process.env.MULTICHAIN) {
  return;
}
```
@GuillaumeRx @metamaskbot @FrederikBolding
Bump PhishingController to 7.0.1 (#21613)
fee7926 
## **Description**

This bumps the `PhishingController` to `7.0.1` after its migration to
`BaseControllerV2`.

- `PhishingController` now takes its restrictred messenger.
- `testOrigin` and `maybeUpdateState` calls are now available through
the messaging system.

The behaviour of the PhishingController should remain the same

---------

Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
@pedronfigueiredo @HowardBraham
fix erc1155 test flakiness (#21628)
e6eb0af 
## **Description**

Fixes test flakiness that causes intermittent failures on `user should
be able to view ERC1155 NFT details @no-mmi`.

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Howard Braham <[email protected]>
@OGPoyraz
Decouple swaps metric logic from TransactionController (#21559)
3fa27cd 
## **Description**
With ongoing effort of `TransactionController` alignment between mobile
and extension, this PR aims to decouple swaps metric logic from
`TransactionController` and make them client specific.

Also removed `transaction-finalized` and put `transaction-confirmed` and
`transaction-failed`. This should've been done before but I couldn't
notice when I was working mainly focused on metric events.

## **Manual testing steps**

No functional changes. 

## **Related issues**

Fixes MetaMask/MetaMask-planning#1053

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've clearly explained:
  - [X] What problem this PR is solving.
  - [X] How this problem was solved.
  - [X] How reviewers can test my changes.
- [X] I’ve indicated what issue this PR is linked to: Fixes #???
- [X] I’ve included tests if applicable.
- [X] I’ve documented any added code.
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@pedronfigueiredo
Mocking IPFS requests on erc1155 tests (#21639)
1754b3d 
## **Description**

Previously, on #21628, a delay to await image load was introduced to fix
the flakiness on the `user should be able to view ERC1155 NFT details`
test. This PR changes the fix to mocking the IPFS response and adds a
mock to the `user should be able to remove ERC1155 NFT on details page`
test too.

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@eriknson @FrederikBolding
One-liner to fill signature content in container (#21585)
d14f91e 
## **Description**

Found a bug where the signature content doesn't fill the popup container
(see attached screenshot).

## **Manual testing steps**

1. Go to e.g. [dydx](https://trade.dydx.exchange/)
2. Trigger a signature
3. Voilá

## **Screenshots/Recordings**

### **Before**
<img width="395" alt="Screenshot 2023-10-27 at 16 21 45"
src="https://github.com/MetaMask/metamask-extension/assets/34306844/e7a99d2b-3f90-4efd-9255-2fa7bb8a9639">


### **After**
<img width="390" alt="Screenshot 2023-10-27 at 16 22 03"
src="https://github.com/MetaMask/metamask-extension/assets/34306844/8b4d4df5-495e-42d1-bc7c-8d8f78cb5ec9">


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Frederik Bolding <[email protected]>
@DDDDDanica
fix(000): style improvement for security provider part in settings (#…
12d6b46 
…21629)

## **Description**

There are some styles mismatching in new security session in settings
tab.

## **Related issues**

Fixes:  N/A

## **Manual testing steps**

1. Go to settings
2. Check experimental tab
3. validate styles in "select your providers"

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="1000" alt="Screenshot 2023-11-01 at 01 59 17"
src="https://github.com/MetaMask/metamask-extension/assets/12678455/bde46819-e411-4217-a0d4-235d558539d8">



### **After**

<img width="1003" alt="Screenshot 2023-11-01 at 02 35 52"
src="https://github.com/MetaMask/metamask-extension/assets/12678455/cdb01c19-a28a-4660-8766-ef0c4f89c58e">


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@darkwing @NidhiKJha
UX: Update querystring for analytics (#21434)
0f09716 
## **Description**

Fixes the querystring for the analytics Iframe to the portfolio.

## **Manual testing steps**

1.  Go through on boarding
2. Ensure that the iframe on the Create Password page has correct
querystring of `?env=production&mmi={SOMESTRING}`


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained:
  - [ ] What problem this PR is solving.
  - [ ] How this problem was solved.
  - [ ] How reviewers can test my changes.
- [ ] I’ve indicated what issue this PR is linked to: Fixes #???
- [ ] I’ve included tests if applicable.
- [ ] I’ve documented any added code.
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Nidhi Kumari <[email protected]>
@darkwing
UX: Send Flow: Convert Recipient Input to TypeScript (#21608)
0b1cec0 
## **Description**

Converts the
`ui/components/multichain/pages/send/components/recipient-input` file to
TypeScript

## **Related issues**

Fixes: None, very small task, no issue needed.

## **Manual testing steps**

No manual test needed

## **Screenshots/Recordings**

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@dbrans
Fix: Contract data reading and parsing (#21604)
6afa47b 
## **Description**
This PR makes two fixes to reading and parsing contract data:
1. `readAddressAsContract` was incorrectly using a promise-style async
call. Fixed to use callback-style async call expected by `eth-query`.
2. `determineTransactionType` was throwing `"cannot read property 'name'
of undefined"` when trying to parse data. However, in the case of a
simple send, data is always undefined. This PR moves the parsing to
where we know we are dealing with a contract.

## **Related issues**

Tracking ticket:
https://github.com/orgs/MetaMask/projects/47/views/1?pane=issue&itemId=43249800

## **Manual testing steps**

No manual testing steps.

## **Screenshots/Recordings**

Not applicable.

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@brad-decker
ci(resources): update parallelism and resource class for e2e tests (#…
aa6dfe9 
…21635)

## **Description**
Update the resource class for all e2e test runners and bump up
parallelism to reduce wait time for e2e tests.

## **Related issues**
N/A

## **Manual testing steps**
1. Go to circle ci and compare develop test run times to this branch
times

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="677" alt="Screenshot 2023-11-01 at 8 51 59 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/0efa8bb8-bff7-48b2-950b-dc3f1009c1b8">

**test-e2e-firefox timings**
<img width="1682" alt="Screenshot 2023-11-01 at 8 52 51 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/5de08f5c-0c31-4f44-a554-a2af80dca64e">

**test-e2e-firefox resources**
<img width="1699" alt="Screenshot 2023-11-01 at 8 53 30 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/ab51c7ed-a76d-4ff0-a57e-c4bfa056a44f">

### **After**
<img width="658" alt="Screenshot 2023-11-01 at 8 54 08 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/28e91a80-a5ac-4c1a-ae03-709b1653e1fb">

**test-e2e-firefox timings*(
<img width="1704" alt="Screenshot 2023-11-01 at 8 54 57 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/67fbf24b-b845-402b-85e2-42fa947fe8b0">

**test-e2e-firefox resources**
<img width="1675" alt="Screenshot 2023-11-01 at 8 55 31 AM"
src="https://github.com/MetaMask/metamask-extension/assets/4448075/9c2b36a5-d9ab-4f24-a584-4ab9fab49990">


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@vthomas13 @DDDDDanica
Multichain: All Connections Listing (#21332)
9688bac 
## **Description**
Added a screen to list all connections, including dapps and snaps in one
place. Connection Details coming in future PRs.
Clicking "Connections" in the app footer will take you to the All
Connections page in fullscreen mode.
Currently, if you have more than 5 total connections (dapps + snaps), it
will switch to a tab mode that separates the connections by type.

## **Manual testing steps**

1. Start the extension, and turn on fullscreen mode.

2. Look for the "Connections" option in the app footer. Click on it to
navigate to the All Connections page. Verify that the All Connections
page opens in fullscreen mode

3. Ensure that all your connections, including dapps and snaps, are
listed on this page.

4. If you have less than 5 total connections, try adding more until you
have more than 5. This can be done by connecting to new dapps or
installing new snaps.

5. Once you have more than 5 total connections, check if the page
switches to a tab mode that separates the connections by type (dapps and
snaps).

6. Try navigating between the tabs and ensure that the correct
connections are displayed for each category.

## **Screenshots/Recordings**


![image](https://github.com/MetaMask/metamask-extension/assets/10986371/10b78570-1b51-4e63-91d7-304540a803f2)


![image](https://github.com/MetaMask/metamask-extension/assets/10986371/7d20ad56-4707-4b53-a8d5-3b43b3d8a002)

## **Related issues**

Fixes https://github.com/MetaMask/MetaMask-planning/issues/916

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've clearly explained:
  - [X] What problem this PR is solving.
  - [X] How this problem was solved.
  - [X] How reviewers can test my changes.
- [X] I’ve indicated what issue this PR is linked to: Fixes #???
- [X] I’ve included tests if applicable.
- [X] I’ve documented any added code.
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [X] I’ve properly set the pull request status:
  - [X] In case it's not yet "ready for review", I've set it to "draft".
- [X] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Danica Shen <[email protected]>
@darkwing @NidhiKJha
UX: Add label to Select Action button (#21634)
909e8e1 
## **Description**

This PR adds an `ariaLabel` attribute to the "Select Action"
`ButtonIcon`, since `ariaLabel` is a required prop.

## **Related issues**

Fixes: N/A

## **Manual testing steps**

1. Use assistive technology
2. Tab to the "Select Action" button in the footer
3. Hear "Select Action" read

## **Screenshots/Recordings**

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Nidhi Kumari <[email protected]>
@NidhiKJha
UX Multichain: Updated account picker in new send flow (#21576)
b9184af 
This PR is to update the account picker in Send Flow

Fixes:
[#1581](MetaMask/MetaMask-planning#1581)

## **Manual testing steps**

1. Go to Send Flow in Multichain Flow
2. Check the account picker matches the figma

## **Screenshots/Recordings**


### **Before**
![Screenshot 2023-10-27 at 2 43 15
PM](https://github.com/MetaMask/metamask-extension/assets/39872794/634fd28e-2816-4cf9-8f4c-c42340446fd1)


### **After**
![Screenshot 2023-10-27 at 2 42 10
PM](https://github.com/MetaMask/metamask-extension/assets/39872794/7c557a3c-a331-4b1e-8361-18c64d42cca9)


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@gauthierpetetin
Fix/actions improvement (#21643)
f5a09c1 
## **Description**

This PR aims to fix a few undesired edge cases, listed
[here](MetaMask/MetaMask-planning#1586), which
have been identified since the introduction of the Github action that
checks issues and PRs templates.

[Same PR for
Mobile.](MetaMask/metamask-mobile#7661)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#1586

## **Manual testing steps**

1. Go on this [test
repo](https://github.com/gauthierpetetin-test/repo_test/)
2. Reproduce scenarios listed in this
[issue](MetaMask/MetaMask-planning#1586)

## **Screenshots/Recordings**

None

### **Before**

None

### **After**

None

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@FrederikBolding @metamaskbot
Bump snaps packages (#21612)
82ceffb 
## **Description**

Bump snaps packages to latest.

Fixes a few small issues and lays the groundwork for exposing links in
custom UI.

---------

Co-authored-by: MetaMask Bot <[email protected]>
@owencraston
patch: Hide "Add Snap accounts" toggle from experimental settings (#2…
a738670 
…1652)

## **Description**
Undoes this pr:
#21221

Due to Unforeseen issues with our snap partners we will need to remove
the "Add Snap accounts" from the main Metamask build. The previous
implementation used a time based toggle to enable this feature. To undo
this change I have remove the timestamp variable and simply set the
toggle to null in main and rendered it in flask.

## **Related issues**

Fixes: #

## **Manual testing steps**

#### Testing main
1. pull this branch `patch/hide-keyring-snaps-toggle`
2. run `yarn install`
3. run `yarn start`
4. load the `dist/chrome` or `dist/firefox` into your browser via
`manage extensions/load unpacked`
5. create a wallet
6. open settings by clicking the 3 dots in the top right corners
7. navigate to `experimental`
8. scroll to the bottom

**EXPECTED**: You _should not_ see `Add Snap accounts`

#### Testing flask
1. pull this branch `patch/hide-keyring-snaps-toggle`
2. 2. run `yarn install`
3. run `yarn start --build-type flask`
4. load the `dist/chrome` or `dist/firefox` into your browser via
`manage extensions/load unpacked`, If you previously manually installed
MetaMask you can skip this step.
5. create a wallet. If you previously manually installed MetaMask you
can skip this step.
6. open settings by clicking the 3 dots in the top right corners
7. navigate to `experimental`
8. scroll to the bottom

**EXPECTED**: You _should_ see `Add Snap accounts`

## **Screenshots/Recordings**

##### MetaMask **Main** build
<img width="424" alt="Screenshot 2023-11-01 at 2 32 37 PM"
src="https://github.com/MetaMask/metamask-extension/assets/22918444/f47b3ed6-c9ab-4004-a164-d2e0489b1412">


##### MetaMask **Flask** Build
<img width="511" alt="Screenshot 2023-11-01 at 1 51 52 PM"
src="https://github.com/MetaMask/metamask-extension/assets/22918444/33b5fe9e-95d1-4f84-8a21-262aa64bf89a">


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sahar-fehri
fix: fix import address with non checksum Adr (#21593)
e00cd4c 
## **Description**


This PR fixes a reported issue here
#21227
The issue happens when the user tries to import an NFT with a non
checksum address.
If you try to import an NFT with a contract address that is a valid
Checksum address twice; you will be able to see the error "NFT already
imported".
If it is an address that is not checksum; it will allow you to import
the NFT twice.

The fix converts the input address to a checksum address and compares it
to the user's NFT object.



## **Related issues**

Fixes: ##21227

## **Manual testing steps**

1. Mint an NFT
2. Import the NFT the first time with decimal
3. Click on import NFT and enter the nonChecksumAddress of the contract
4. Input the NFT ID and you should see the error

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

For this test, we deployed a contract: this is the contract address from
etherscan: 0x80AcDDE51B1f379AE60f72203bfD24D4d6D4412d (Which is a valid
checksum address)
And this is the address we will test with:
0x80acdde51b1f379ae60f72203bfd24d4d6d4412d (which is a non valid
checksum address)

Using the valid checksum address you should see:


![image](https://github.com/MetaMask/metamask-extension/assets/10994169/8854fa1c-1954-4479-82d9-1355fcff58e3)

Using the non valid checksum address you see:


![image](https://github.com/MetaMask/metamask-extension/assets/10994169/fb4e8039-14d9-47a7-86bc-9104a64a46df)


### **After**

Still Works with valid checksum address for decimal

![image](https://github.com/MetaMask/metamask-extension/assets/10994169/6ab4419f-c7a7-4e71-9936-39723dea976c)

Still works with valid checksum address for hex

![image](https://github.com/MetaMask/metamask-extension/assets/10994169/bf1d79e3-ed9e-4033-8b99-0d42938e5a5e)

Works with non valid checksum address decimal using
(0x80acdde51b1f379ae60f72203bfd24d4d6d4412d)


![image](https://github.com/MetaMask/metamask-extension/assets/10994169/8c6d408d-3aca-45d8-ae67-c0c11acd97e5)

Works with non valid checksum address for hex 


![image](https://github.com/MetaMask/metamask-extension/assets/10994169/887150c4-97bc-4d7f-847e-7919fde68600)


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@vinistevam
Replace MMI code fence with callbacks and arguments (#21171)
ebe4694 
## **Description**
This PR aims to replace MMI code fences with callbacks and arguments to
prepare (subsequent ticket) the support of the code in the Transaction
Controller in the core repo as it is a static package and cannot have
any build-specific code.

This effort is part of the unification of the Transaction Controller.
@zone-live
[MMI] enables simple send test (#21616)
e769167 
## **Description**

Enables the `Simple Send` test for MMI build.


## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained:
  - [x] What problem this PR is solving.
  - [x] How this problem was solved.
  - [x] How reviewers can test my changes.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@zone-live
[MMI] passing the selectedAddress field (#21617)
2bda081 
## **Description**

In MMI we need the address selected to be sent in the properties, so in
order to have that we get the `selectedAddress` from preferences state
and pass it to the `mmiProps` object.


## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained:
  - [x] What problem this PR is solving.
  - [x] How this problem was solved.
  - [x] How reviewers can test my changes.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@GuillaumeRx
Remove derived targetSubjectMetadata from state and use props (#21539)
81d2c4c
@digiwand
fix:style: Apply 100% width to Sign-in With Ethereum (SIWE) popup (#2…
da4a99b 
…1645)

## **Description**

When opening the Sign-in with Ethereum pop-up UI, it may not span the
entire width. This PR applies width 100% to ensure it spans the width.
There is an existing media query to support when the window is wider in
which it has a fixed width, not 100%

## **Related issues**

Fixes: MetaMask/MetaMask-planning#1610

## **Manual testing steps**
1. Open test Dapp
2. Issue sign-in with Ethereum transaction
3. Observe width 


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
![Screenshot 2023-11-01 at 4 56
34 PM](https://github.com/MetaMask/metamask-extension/assets/20778143/306e463e-06fc-4e82-82cb-e2854e8db2f8)

<!-- [screenshots/recordings] -->

### **After**

![Screenshot 2023-11-01 at 4 57
34 PM](https://github.com/MetaMask/metamask-extension/assets/20778143/96db14a1-4657-4852-8584-712a54d9c457)
<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@GuillaumeRx
Fix Text inherit variant (#21664)
d849353
@shanejonas @metamaskbot
@adonesky1 @jiexi
Added multichain polling to DetectTokensController via PollingControl…
83c4e41 
…lerOnly (#21572)

## **Description**
Implemented multichain polling in DetectTokensController through
inheritance from PollingControllerOnly, enabling simultaneous network
polling.


## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1556

---------

Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: Alex Donesky <[email protected]>
Co-authored-by: jiexi <[email protected]>
@HowardBraham
e2e: with the newest version of Selenium, manually updating Geckodriv…
6ce0e8d 
…er and Chromedriver is no longer necessary (#21481)

Yay! We don't have to manually update Geckodriver and Chromedriver anymore, so they shouldn't get out of sync!

https://www.selenium.dev/blog/2023/whats-new-in-selenium-manager-with-selenium-4.11.0/
montelaidev and others added 12 commits November 9, 2023 17:40
@montelaidev
Update snap builder to use controller messenger (#21712)
16592dd 
This PR updates the snap build to use the controller messenger in place of passing controllers into the builder.
@FrederikBolding
Bump snaps packages (#21774)
bd6adcb 
## **Description**

Bump snaps packages to latest.

Summary of changes in the snaps deps:
- Add support for unencrypted state
- Add `onHomePage` export and endowment
- Add manifest localization support
- Fix some issues with stream communication
@zone-live
[MMI] show unsupported networks message in address tooltip (#21745)
de440d9 
## **Description**

In MMI we don't support all networks therefore we want to prevent the
user from copying the account address while at the same time show in the
tooltip that information.

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
We would allow to copy the address and don't show any message.

### **After**
When connecting to a weird network like
[Boba](https://chainlist.org/chain/288):

<img width="354" alt="Screenshot 2023-11-08 at 14 13 03"
src="https://github.com/MetaMask/metamask-extension/assets/1125631/ee5ccf0b-4625-4c33-bd09-18d5811c605a">


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@zone-live
[MMI] add missing mmi status in tx detail pane (#21777)
30d32d4 
## **Description**

Adds the missing transaction custodial status to the Tx detail, and
cleans up the logic there a bit.
Also adds the custodian website as a fallback to the property
custodianURL.

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@zone-live @DDDDDanica
[MMI] Improves css styles in mmi view (#21779)
8cc5cc4 
## **Description**

- Fixes a few styles for the custodial list view.
- Removes a code fence that wasn't doing anything.

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Danica Shen <[email protected]>
@HowardBraham
e2e: temporary band-aid to flaky test in errors.spec.js (#21789)
bef1a34
@salimtb
fix: ERC721 name does not display when approving token (#21796)
b0cabd5 
## **Description**

whenever we are approving an ERC721 token, we can see how the collection
name is not displayed if an nft was imported.
if it's not imported it works fine.

Expected behavior
The collection name should be displayed in the same way it's done for
Set Approval For All / Revoke screens.

## **Related issues**

Fixes:
#[21756](#21756)

## **Manual testing steps**

1. Go to metamask E2E test dapp and deploy ERC721 contract
2. Mint an NFT
3. watch this NFT ( or import it to metamask )
4. execute the method Approve

## **Screenshots/Recordings**

### **Before**

<img width="359" alt="before"
src="https://github.com/MetaMask/metamask-extension/assets/26223211/0184016e-24f8-4b8d-b1a6-756be695eaf3">

### **After**
<img width="358" alt="after"
src="https://github.com/MetaMask/metamask-extension/assets/26223211/41206001-7c5b-4c89-838c-e4da1799c893">

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@dhruvv173 @georgewrmarshall @garrettbear
Fix: Migrate TextField to TS (#20477)
c8b0637 
## Explanation
This PR focuses on the migration of the `TextField` component, currently
in JavaScript, from the component-library folder to TypeScript. As part
of this process, the JavaScript version is now deprecated.

To minimize disruption to the application, we have updated all import
paths from the JavaScript version to point to the deprecated version.

Following the approval and merge of this PR, we will proceed to replace
every instance of the deprecated JavaScript component with the new
TypeScript version. We will ensure that all functionalities are working
as expected after this transition.

* Fixes #19127 

## Screenshots/Screencaps

### Before



https://github.com/MetaMask/metamask-extension/assets/8112138/3e61fe03-bf41-48e5-8e9f-4618df7a5b3a



### After



https://github.com/MetaMask/metamask-extension/assets/8112138/4523091c-7826-471a-8b3f-951b991908c1



## Manual Testing Steps

- Go to the storybook build of this PR
- Search `TextField` in the search bar and go to the component-library
version
- Check documentation, stories and controls 

## Pre-merge author checklist

- [x] I've clearly explained:
  - [x] What problem this PR is solving
  - [x] How this problem was solved
  - [x] How reviewers can test my changes

## Pre-merge reviewer checklist

- [x] Sufficient automated test coverage has been added
- [x] Manual testing (e.g. pull and build branch, run in browser, test
code being changed)
- [x] PR is linked to the appropriate GitHub issue
- [ ] **IF** this PR fixes a bug in the release milestone, add this PR
to the release milestone

If further QA is required (e.g. new feature, complex testing steps,
large refactor), add the `Extension QA Board` label.

In this case, a QA Engineer approval will be be required.

---------

Co-authored-by: georgewrmarshall <[email protected]>
Co-authored-by: Garrett Bear <[email protected]>
Co-authored-by: George Marshall <[email protected]>
@sahar-fehri
feat: Add SEK currency (#21782)
0ab1537 
## **Description**

This PR adds the currency "sek" to the list of available currencies

## **Related issues**

Fixes: ##21736

## **Manual testing steps**

1. Go to settings page
2.Choose SEK as currency
3.Go back to home page and see the currency conversion in SEK

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

You cannot find SEK on this list

![image](https://github.com/MetaMask/metamask-extension/assets/10994169/a6eaf9f9-7164-403e-baef-d38f69276db3)

### **After**

You find SEK in the list 

![image](https://github.com/MetaMask/metamask-extension/assets/10994169/4f4b8195-cecc-4284-870e-69c8b070b294)

And you can see currency conversion


![image](https://github.com/MetaMask/metamask-extension/assets/10994169/da2c0650-150d-4618-b2ec-3ec215b93800)


## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@pedronfigueiredo @danjm
@seaona @HowardBraham @FrederikBolding @owencraston @zone-live @jpuri @micaelae @blackdevelopa @salimtb @chloeYue
Master sync following v11.5.0 (#21815)
2d282ef 
## **Description**
  
  ## **Related issues**
  
  ## **Manual testing steps**
  
  ## **Screenshots/Recordings**
  
  ### **Before**
  
  ### **After**
  
  ## **Pre-merge author checklist**
  
  ## **Pre-merge reviewer checklist**

---------

Co-authored-by: Dan J Miller <[email protected]>
Co-authored-by: seaona <[email protected]>
Co-authored-by: Howard Braham <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Owen Craston <[email protected]>
Co-authored-by: António Regadas <[email protected]>
Co-authored-by: Jyoti Puri <[email protected]>
Co-authored-by: micaelae <[email protected]>
Co-authored-by: Sylva Elendu <[email protected]>
Co-authored-by: salimtb <[email protected]>
Co-authored-by: Chloe Gao <[email protected]>
@FrederikBolding
Add loading state for snap delineator (#21792)
71e3f2c 
## **Description**

Adds a loading state for the snaps delineator component and uses it for
transaction insights.

## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-extension/assets/1561200/a1d1e1b8-25a2-47e0-9c51-09cbd4207c02
@darkwing
UX: Send Flow: Place Amount field in content (#21744)
b90956b 
## **Description**

Brian did a great job creating the `AssetPicker` but we need to shift it
into just the content view (i.e. not show it until the user has picked a
recipient). This PR accomplishes that, with a few cleanups as well.

## **Related issues**

Fixes: N/A

## **Manual testing steps**

1. Go to the new send flow
2. Don't see the AssetPicker
3. Choose a recipient
4. See the AssetPicker

## **Screenshots/Recordings**

### **Before**

N/A

### **After**

<img width="402" alt="SCR-20231107-pudu"
src="https://github.com/MetaMask/metamask-extension/assets/46655/a5cd9972-5e1a-40a6-81d8-874fffcb3950">



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 23, 2023
@socket-security Socket Security
Copy link

socket-security bot commented Nov 23, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/queued-request-controller 0.1.4 None +3 316 kB metamaskbot
@metamask/polling-controller 1.0.2 None +2 273 kB metamaskbot
blo 1.1.1 None +0 28.9 kB bpierre
@metamask/phishing-warning 2.1.0...3.0.0 None +0/-0 1.7 MB metamaskbot
@metamask/smart-transactions-controller 4.0.0...6.2.2 None +0/-1 119 kB metamaskbot
@metamask/ppom-validator 0.8.0...0.10.0 None +0/-0 135 kB metamaskbot
@metamask/eth-trezor-keyring 1.1.0...2.0.0 None +0/-0 81.8 kB metamaskbot
@metamask/selected-network-controller 2.0.1...3.1.2 None +2/-1 271 kB metamaskbot

🚮 Removed packages: @download/[email protected], @metamask/[email protected], @metamask/[email protected], @truffle/[email protected], @truffle/[email protected], [email protected], [email protected], [email protected]

@socket-security Socket Security
Copy link

socket-security bot commented Nov 23, 2023 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author @metamask/eth-query 4.0.0
Unstable ownership @metamask/eth-query 4.0.0

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

danjm and others added 9 commits November 23, 2023 16:07
@danjm
Revert "Revert "feat: Add metrics for provider calls coming from ppom…
14e48fe 
… on extenson (#21482) (#21757)"

This reverts commit e2b4c89.
@danjm
Revert "Revert "feat: Metrics for when Blockaid banner is shown. (#21396
46748be 
)" (#21772)"

This reverts commit a114092.
@danjm
Merge branch 'master' into Version-v11.6.0
899202a
@chloeYue @danjm
v11.6.0
23b10c1
@dan437 @danjm
Clear current STX error (#21848) (#21858)
dbec24d 
## **Description**

There were no merge conflicts when cherry picking this commit.
@dan437 @danjm
Cherry pick: Remove unnecessary redirection / code from Swaps, update…
aa3ec5a 
… content (#21945)

## **Description**
Cherry pick of this code:
#21935
@adonesky1 @danjm
Cherry pick: Fix issue where per dapp selected network state is enabl… (
4d6837e 
#21951)

Cherry-pick
3388599
(PR #21946) to
v11.6.0

**There were no merge conflicts when picking these commits**
@legobeat @danjm
[v11.6.0] deps: lockbump @metamask/eth-sig-util to 6.0.2 and 7.0.1 (#…
8a5d61f 
…21954)

- #21928 targeting v11.6.0
@mcmire @danjm
Ignore @metamask/snaps-ui deprecation (#21896)
0345a1b 
`@metamask/snaps-ui` is indirectly used by `@metamask/keyring-api` but
is deprecated, so we are getting an audit failure. Replacing
`@metamask/snaps-ui` with `@metamask/snaps-sdk` will solve this but in
the meantime we are ignoring this deprecation to unblock further merges.
@danjm danjm merged commit 0345a1b into master Nov 24, 2023
70 of 74 checks passed
@danjm danjm deleted the v11.6.0-temp23 branch November 24, 2023 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kumavis kumavis Awaiting requested review from kumavis kumavis will be requested when the pull request is marked ready for review kumavis is a code owner

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.