-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore @metamask/snaps-ui deprecation #21896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
`@metamask/snaps-ui` is indirectly used by `@metamask/keyring-api` but is deprecated, so we are getting an audit failure. Replacing `@metamask/snaps-ui` with `@metamask/snaps-sdk` will solve this but in the meantime we are ignoring this deprecation to unblock further merges.
mcmire
force-pushed
the
ignore-snaps-ui-deprecation
branch
from
November 20, 2023 20:56
ee23a9d
to
93e0049
Compare
jiexi
approved these changes
Nov 20, 2023
FrederikBolding
approved these changes
Nov 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21896 +/- ##
========================================
Coverage 68.43% 68.43%
========================================
Files 1048 1048
Lines 41672 41672
Branches 11100 11100
========================================
Hits 28516 28516
Misses 13156 13156 ☔ View full report in Codecov by Sentry. |
Builds ready [93e0049]
Page Load Metrics (490 ± 267 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.7.0
Issue or pull request that will be included in release 11.7.0
label
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-11.7.0
Issue or pull request that will be included in release 11.7.0
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@metamask/snaps-ui
is indirectly used by@metamask/keyring-api
but is deprecated, so we are getting an audit failure. Replacing@metamask/snaps-ui
with@metamask/snaps-sdk
will solve this but in the meantime we are ignoring this deprecation to unblock further merges.Pre-merge author checklist
Pre-merge reviewer checklist