Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore @metamask/snaps-ui deprecation #21896

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 20, 2023

Description

@metamask/snaps-ui is indirectly used by @metamask/keyring-api but is deprecated, so we are getting an audit failure. Replacing @metamask/snaps-ui with @metamask/snaps-sdk will solve this but in the meantime we are ignoring this deprecation to unblock further merges.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mcmire mcmire requested a review from a team as a code owner November 20, 2023 20:55
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

`@metamask/snaps-ui` is indirectly used by `@metamask/keyring-api` but
is deprecated, so we are getting an audit failure. Replacing
`@metamask/snaps-ui` with `@metamask/snaps-sdk` will solve this but in
the meantime we are ignoring this deprecation to unblock further merges.
@mcmire mcmire force-pushed the ignore-snaps-ui-deprecation branch from ee23a9d to 93e0049 Compare November 20, 2023 20:56
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00b9612) 68.43% compared to head (93e0049) 68.43%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21896   +/-   ##
========================================
  Coverage    68.43%   68.43%           
========================================
  Files         1048     1048           
  Lines        41672    41672           
  Branches     11100    11100           
========================================
  Hits         28516    28516           
  Misses       13156    13156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [93e0049]
Page Load Metrics (490 ± 267 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8412596105
domContentLoaded6511985147
load801428490556267
domInteractive6511985147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mcmire mcmire merged commit 5bca179 into develop Nov 20, 2023
68 checks passed
@mcmire mcmire deleted the ignore-snaps-ui-deprecation branch November 20, 2023 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@metamaskbot metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants