-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Text
inherit
variant
#21664
Fix Text
inherit
variant
#21664
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21664 +/- ##
========================================
Coverage 68.84% 68.85%
========================================
Files 1040 1040
Lines 41443 41443
Branches 11068 11068
========================================
+ Hits 28531 28532 +1
+ Misses 12912 12911 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [02d8528]
Page Load Metrics (1553 ± 304 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @GuillaumeRx 🙏
Description
This moves the
Text
component&--inherit
class higher in the CSS hierarchi to avoid it overwriting any passed props.Related issues
Fixes: #21626
Manual testing steps
Text
component with abodyMd
variant and add afontWeight
prop (likebold
)font-weight
attribute you just set not being overwrited byinherit
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist