Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snaps website link pointing to the wrong URL #21619

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

FrederikBolding
Copy link
Member

Description

Fixes the snaps website link pointing to the wrong URL.

Testing steps:

  1. Install https://snaps.metamask.io/snap/npm/tezos-metamask-snap/
  2. Click website link in snap settings
  3. See that you are navigated to https://metamask.tezos.com/

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Oct 31, 2023
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 31, 2023 14:46
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@HowardBraham HowardBraham force-pushed the fb/fix-snap-website-link branch from f9ccd1c to dcbc244 Compare October 31, 2023 18:59
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dec3b18) 68.82% compared to head (dcbc244) 68.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21619   +/-   ##
========================================
  Coverage    68.82%   68.82%           
========================================
  Files         1035     1035           
  Lines        41205    41205           
  Branches     10994    10994           
========================================
  Hits         28359    28359           
  Misses       12846    12846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HowardBraham HowardBraham merged commit 51dbd52 into develop Oct 31, 2023
9 checks passed
@HowardBraham HowardBraham deleted the fb/fix-snap-website-link branch October 31, 2023 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Oct 31, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [dcbc244]
Page Load Metrics (1177 ± 389 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84130100147
domContentLoaded7212793189
load8320851177810389
domInteractive7212793189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -7 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-11.4.1 Issue or pull request that will be included in release 11.4.1 and removed release-11.6.0 Issue or pull request that will be included in release 11.6.0 labels Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.4.1 Issue or pull request that will be included in release 11.4.1 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants