-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: Add metrics for provider calls coming from ppom on extenson (#21482) #21757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [173ba47]
Page Load Metrics (1355 ± 310 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
segun
approved these changes
Nov 9, 2023
blackdevelopa
approved these changes
Nov 9, 2023
danjm
force-pushed
the
revert-confirmations-metrics
branch
from
November 10, 2023 00:29
173ba47
to
ce4e2d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.5.0 #21757 +/- ##
===================================================
- Coverage 68.82% 68.81% -0.01%
===================================================
Files 1035 1035
Lines 41196 41187 -9
Branches 10997 10992 -5
===================================================
- Hits 28353 28341 -12
- Misses 12843 12846 +3
☔ View full report in Codecov by Sentry. |
Builds ready [ce4e2d7]
Page Load Metrics (804 ± 383 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsion (#21482)"
This reverts commit 0a261a8.
Description
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist