Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable it failing block for ppom malicious signature #21627

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 31, 2023

Description

Disabling e2e test for malicious signatures, until fixed

Related issues

Fixes: #

Manual testing steps

Check ci is passing // test is not executed

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner October 31, 2023 18:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Oct 31, 2023
@HowardBraham HowardBraham merged commit dec3b18 into develop Oct 31, 2023
15 of 16 checks passed
@HowardBraham HowardBraham deleted the test-disable-ppom branch October 31, 2023 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Oct 31, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [f261706]
Page Load Metrics (1584 ± 435 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84138108189
domContentLoaded691341022010
load8025671584905435
domInteractive691341022010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants