Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PhishingController to 7.0.1 #21613

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

GuillaumeRx
Copy link
Contributor

Description

This bumps the PhishingController to 7.0.1 after its migration to BaseControllerV2.

  • PhishingController now takes its restrictred messenger.
  • testOrigin and maybeUpdateState calls are now available through the messaging system.

The behaviour of the PhishingController should remain the same

@GuillaumeRx GuillaumeRx added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Oct 31, 2023
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 31, 2023 11:05
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected]

@GuillaumeRx
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners October 31, 2023 11:32
@GuillaumeRx GuillaumeRx force-pushed the gr/bump-phishing-controller branch from 9a60cce to fe6ada3 Compare October 31, 2023 14:44
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [a9866a3]
Page Load Metrics (1197 ± 347 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85140102157
domContentLoaded7711794105
load8718651197723347
domInteractive7711794105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -46.51 KiB (-1.15%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit fee7926 into develop Nov 1, 2023
9 checks passed
@FrederikBolding FrederikBolding deleted the gr/bump-phishing-controller branch November 1, 2023 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants