Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] enables simple send test #21616

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 31, 2023

Description

Enables the Simple Send test for MMI build.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner October 31, 2023 13:57
@zone-live zone-live added the team-mmi PRs from the MMI team label Oct 31, 2023
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@zone-live zone-live removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@zone-live zone-live changed the title MMI enables simple send test [MMI] enables simple send test Oct 31, 2023
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e00cd4c) 68.83% compared to head (1e1acab) 68.83%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21616   +/-   ##
========================================
  Coverage    68.83%   68.83%           
========================================
  Files         1039     1039           
  Lines        41398    41398           
  Branches     11057    11057           
========================================
  Hits         28496    28496           
  Misses       12902    12902           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1e1acab]
Page Load Metrics (1580 ± 362 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92151108168
domContentLoaded76142100168
load8722611580754362
domInteractive76142100168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit e769167 into develop Nov 2, 2023
9 checks passed
@zone-live zone-live deleted the MMI-add-the-simple-send-spec-to-mmi branch November 2, 2023 10:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants