Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Metrics for when Blockaid banner is shown. (#21396)" #21772

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 9, 2023

This reverts commit 8a96c2b.

Description

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [c7d02cf]
Page Load Metrics (1234 ± 405 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9312410394
domContentLoaded7612395126
load8821741234843405
domInteractive7612394126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0.00%)
  • ui: -6.26 KiB (-0.08%)
  • common: 0 Bytes (0.00%)

@seaona seaona marked this pull request as ready for review November 9, 2023 11:48
@seaona seaona requested a review from a team as a code owner November 9, 2023 11:48
@danjm danjm force-pushed the revert-confirmations-metrics-2 branch from c7d02cf to 551d7a1 Compare November 10, 2023 00:28
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2bf175) 68.82% compared to head (551d7a1) 68.79%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v11.5.0   #21772      +/-   ##
===================================================
- Coverage            68.82%   68.79%   -0.03%     
===================================================
  Files                 1035     1035              
  Lines                41196    41152      -44     
  Branches             10997    10985      -12     
===================================================
- Hits                 28353    28309      -44     
  Misses               12843    12843              
Files Coverage Δ
...t-original/signature-request-original.component.js 58.00% <ø> (-2.00%) ⬇️
...p/signature-request-siwe/signature-request-siwe.js 71.93% <ø> (-2.26%) ⬇️
...ponents/app/signature-request/signature-request.js 82.19% <ø> (-0.93%) ⬇️
...nents/app/transaction-alerts/transaction-alerts.js 97.30% <ø> (-0.26%) ⬇️
ui/helpers/utils/metrics.js 100.00% <ø> (ø)
...prove-content/confirm-approve-content.component.js 78.03% <ø> (-0.62%) ⬇️
ui/pages/token-allowance/token-allowance.js 70.19% <ø> (-0.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [551d7a1]
Page Load Metrics (1342 ± 502 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint851871273216
domContentLoaded681711122613
load82270413421045502
domInteractive681711122613
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0.00%)
  • ui: -6.26 KiB (-0.08%)
  • common: 0 Bytes (0.00%)

@danjm danjm merged commit a114092 into Version-v11.5.0 Nov 10, 2023
63 checks passed
@danjm danjm deleted the revert-confirmations-metrics-2 branch November 10, 2023 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants