Remove unnecessary redirection / code from Swaps, update content

[dan437]

Description

This PR solves 3 things:

• There was an issue with duplicated redirection to the Notification Page (which we already do here), which caused unnecessary redirects between the Prepare Swap Page and Notification Page in Swaps.
• Also, we had some duplicated code that was not needed after Swaps redesign and because of that we showed the Notification Page (see the screenshot), instead of fetching quotes again on the Prepare Swap Page, which would save users some time.
• Update content (Start swapping -> Enable Smart Swaps)

Why the removed code was not needed:

• Quotes fetching is done in the prepare-swap-page component: https://github.com/MetaMask/metamask-extension/blob/develop/ui/pages/swaps/prepare-swap-page/prepare-swap-page.js#L628
• this.setSwapsErrorKey(QUOTES_EXPIRED_ERROR); is done in the SwapsController: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/controllers/swaps.js#L440

The functions that were used from the deleted code are still used in the old Swaps design (our fallback solution). Once we will be cleaning up the old Swaps design code, those functions will be removed as well.

Screenshots

Updated content:

Notification page:

Testing Steps

Test 1 - make sure Swaps work and we still show the Notification Page if a user stayed on the Prepare Swap Page too long with everything filled in

Test 2 - Show the Prepare Swap Page instead of the Notification Page after clicking on the "Try Again" link:

• Open Swaps
• Make sure Smart Swap is enabled
• Make a swap and immediately cancel it
• Wait on the Smart Transaction Status page for 5 minutes
• Click on the "Try Again" button
• See that you will be redirected to Prepare Swap Page and new quotes fetching will start instead of going to the Notification Page

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [bf4f198]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (683 ± 257 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	138	100	15	7
		domContentLoaded	66	111	88	14	7
		load	78	1380	683	536	257
		domInteractive	66	111	88	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: -279 Bytes (-0.00%)
• common: 7 Bytes (0.00%)

[davibroc]

I have tested it and seems that the bug has been fixed

[metamaskbot]

More than one release label on PR. Keeping the lowest one (release-11.6.0) on PR and removing other release labels (release-11.7.0).