Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix erc1155 test flakiness #21628

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix erc1155 test flakiness #21628

merged 2 commits into from
Nov 1, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

Description

Fixes test flakiness that causes intermittent failures on user should be able to view ERC1155 NFT details @no-mmi.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
DDDDDanica
DDDDDanica previously approved these changes Oct 31, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [c9cdc07]
Page Load Metrics (980 ± 354 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811189084
domContentLoaded6711583105
load781752980736354
domInteractive6711583105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74a7ab5) 68.80% compared to head (c9cdc07) 68.80%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21628   +/-   ##
========================================
  Coverage    68.80%   68.80%           
========================================
  Files         1037     1037           
  Lines        41285    41285           
  Branches     11020    11020           
========================================
  Hits         28403    28403           
  Misses       12882    12882           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronfigueiredo pedronfigueiredo merged commit e6eb0af into develop Nov 1, 2023
9 checks passed
@pedronfigueiredo pedronfigueiredo deleted the fix/erc1155-test branch November 1, 2023 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants