You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MMI we need the address selected to be sent in the properties, so in order to have that we get the selectedAddress from preferences state and pass it to the mmiProps object.
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
All modified and coverable lines are covered by tests ✅
Comparison is base (e00cd4c) 68.83% compared to head (b7a0c74) 68.83%.
Report is 2 commits behind head on develop.
❗ Current head b7a0c74 differs from pull request most recent head 963c4bb. Consider uploading reports for the commit 963c4bb to get more accurate results
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.6.0Issue or pull request that will be included in release 11.6.0team-mmiPRs from the MMI team
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In MMI we need the address selected to be sent in the properties, so in order to have that we get the
selectedAddress
from preferences state and pass it to themmiProps
object.Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist