Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] passing the selectedAddress field #21617

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 31, 2023

Description

In MMI we need the address selected to be sent in the properties, so in order to have that we get the selectedAddress from preferences state and pass it to the mmiProps object.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Oct 31, 2023
@zone-live zone-live requested a review from a team as a code owner October 31, 2023 14:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 31, 2023
…taMask/metamask-extension into MMI-4044-passing-accountAddress-field
@metamaskbot
Copy link
Collaborator

Builds ready [b7a0c74]
Page Load Metrics (1552 ± 354 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97140110105
domContentLoaded80137102126
load9222221552738354
domInteractive80137102126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e00cd4c) 68.83% compared to head (b7a0c74) 68.83%.
Report is 2 commits behind head on develop.

❗ Current head b7a0c74 differs from pull request most recent head 963c4bb. Consider uploading reports for the commit 963c4bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21617      +/-   ##
===========================================
- Coverage    68.83%   68.83%   -0.00%     
===========================================
  Files         1039     1039              
  Lines        41398    41401       +3     
  Branches     11057    11058       +1     
===========================================
+ Hits         28496    28498       +2     
- Misses       12902    12903       +1     
Files Coverage Δ
app/scripts/controllers/metametrics.js 80.50% <100.00%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

racitores
racitores previously approved these changes Nov 2, 2023
NidhiKJha
NidhiKJha previously approved these changes Nov 2, 2023
@zone-live zone-live requested a review from racitores November 2, 2023 10:29
@zone-live zone-live merged commit 2bda081 into develop Nov 2, 2023
9 checks passed
@zone-live zone-live deleted the MMI-4044-passing-accountAddress-field branch November 2, 2023 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [963c4bb]
Page Load Metrics (1685 ± 269 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87130104147
domContentLoaded6912297147
load8022711685560269
domInteractive6912297147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants