Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where per dapp selected network state is enabled without the request queue experimental toggle enabled #21946

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Nov 22, 2023

In #21522, the perDomainNetwork state was left as always enabled. This state should be toggled on and off with the Select networks for each site experimental setting.

Fixes: #21876

Manual testing steps

Pertaining to the fix for #21876

  1. Load MetaMask and the test dapp: https://metamask.github.io/test-dapp/
  2. Switch to Sepolia and connect MetaMask to the test dapp
  3. Switch to Goerli --> Notice that no TST tokens are displayed
  4. Switch to Sepolia again
  5. In the test dapp, deploy erc-20 contract
  6. Confirm the request
  7. Proceed to add token/watch asset
  8. Confirm the request
  9. In the tokens list, see that the TST token is present on Sepolia

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@adonesky1 adonesky1 requested a review from a team as a code owner November 22, 2023 18:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 22, 2023
@adonesky1 adonesky1 force-pushed the fix-experimental-toggle branch from 64e34f1 to ed1ff12 Compare November 22, 2023 19:06
@adonesky1 adonesky1 requested review from shanejonas, jiexi, a team and danjm November 22, 2023 19:07
@adonesky1 adonesky1 changed the title Fx issue where per dapp selected network state is enabled without the request queue experimental toggle enabled Fix issue where per dapp selected network state is enabled without the request queue experimental toggle enabled Nov 22, 2023
@adonesky1 adonesky1 merged commit 3388599 into develop Nov 22, 2023
66 of 68 checks passed
@adonesky1 adonesky1 deleted the fix-experimental-toggle branch November 22, 2023 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@metamaskbot metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [e223b71]
Page Load Metrics (658 ± 297 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91154111178
domContentLoaded7013198178
load831502658618297
domInteractive7013198178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 76 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Watch Asset request sends the response on a wrong network
4 participants