[Bug]: Watch Asset request sends the response on a wrong network #21876
Assignees
Labels
regression-prod-11.6.0
Regression bug that was found in production in release 11.6.0
release-11.6.0
Issue or pull request that will be included in release 11.6.0
release-11.7.0
Issue or pull request that will be included in release 11.7.0
release-blocker
This bug is blocking the next release
team-assets
type-bug
Comments
benjisclowder
added
type-bug
team-confirmations-secure-ux
metamaskbot
added
the
regression-prod-11.6.0
bschorchit
added
team-assets
and removed
team-confirmations-secure-ux
13 tasks
adonesky1
added a commit
that referenced
this issue
Nov 22, 2023
…e request queue experimental toggle enabled (#21946) In #21522, the `perDomainNetwork` state was left as always enabled. This state should be toggled on and off with the `Select networks for each site` experimental setting. Fixes: #21876 ## **Manual testing steps** Pertaining to the fix for #21876 1. Load MetaMask and the test dapp: https://metamask.github.io/test-dapp/ 2. Switch to Sepolia and connect MetaMask to the test dapp 3. Switch to Goerli --> Notice that no TST tokens are displayed 4. Switch to Sepolia again 5. In the test dapp, deploy erc-20 contract 6. Confirm the request 7. Proceed to add token/watch asset 8. Confirm the request 9. In the tokens list, see that the TST token is present on Sepolia ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-11.7.0
chloeYue
removed
the
release-11.7.0
metamaskbot
added
the
release-11.7.0
|
Missing release label release-11.7.0 on issue. Adding release label release-11.7.0 on issue, as issue is linked to PR #21946 which has this release label. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Deploying contract for erc-20 on the Test Dapp while on the Sepolia network gives a successful response, but the next step, watching the asset or adding it to the wallet sends confirmation on Sepolia, but the tokens are then displayed on Goerli network, without any contract being deployed there.
Expected behavior
Watch Asset request should send a confirmation on Sepolia for contracts deployed on the same network and upon confirmation, the assets are displayed on the chosen network (Sepolia here).
Screenshots/Recordings
Screen.Recording.2023-11-17.at.13.48.05.mov
Steps to reproduce
Error messages or log output
No response
Version
11.6.0
Build type
None
Browser
Chrome, Firefox
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: