Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/actions improvement #21643

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Fix/actions improvement #21643

merged 7 commits into from
Nov 1, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Nov 1, 2023

Description

This PR aims to fix a few undesired edge cases, listed here, which have been identified since the introduction of the Github action that checks issues and PRs templates.

Same PR for Mobile.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1586

Manual testing steps

  1. Go on this test repo
  2. Reproduce scenarios listed in this issue

Screenshots/Recordings

None

Before

None

After

None

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1754b3d) 68.78% compared to head (6a852a3) 68.78%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21643   +/-   ##
========================================
  Coverage    68.78%   68.78%           
========================================
  Files         1037     1037           
  Lines        41316    41316           
  Branches     11027    11027           
========================================
  Hits         28418    28418           
  Misses       12898    12898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [6a852a3]
Page Load Metrics (1447 ± 277 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811099384
domContentLoaded661048784
load7618521447576277
domInteractive661048784
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin merged commit f5a09c1 into develop Nov 1, 2023
15 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/actions-improvement branch November 1, 2023 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants