-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/actions improvement #21643
Merged
Merged
Fix/actions improvement #21643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MPLATE label removed
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21643 +/- ##
========================================
Coverage 68.78% 68.78%
========================================
Files 1037 1037
Lines 41316 41316
Branches 11027 11027
========================================
Hits 28418 28418
Misses 12898 12898 ☔ View full report in Codecov by Sentry. |
Builds ready [6a852a3]
Page Load Metrics (1447 ± 277 ms)
Bundle size diffs
|
brad-decker
approved these changes
Nov 1, 2023
DDDDDanica
approved these changes
Nov 1, 2023
metamaskbot
added
the
release-11.6.0
Issue or pull request that will be included in release 11.6.0
label
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.6.0
Issue or pull request that will be included in release 11.6.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a few undesired edge cases, listed here, which have been identified since the introduction of the Github action that checks issues and PRs templates.
Same PR for Mobile.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1586
Manual testing steps
Screenshots/Recordings
None
Before
None
After
None
Pre-merge author checklist
Pre-merge reviewer checklist