Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking IPFS requests on erc1155 tests #21639

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

Description

Previously, on #21628, a delay to await image load was introduced to fix the flakiness on the user should be able to view ERC1155 NFT details test. This PR changes the fix to mocking the IPFS response and adds a mock to the user should be able to remove ERC1155 NFT on details page test too.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Previously, on #21628, a delay was introduced to fix flakiness on the
`user should be able to view ERC1155 NFT details` test. This PR changes
the fix to mocking the IPFS response and adds a mock to the `user should
be able to remove ERC1155 NFT on details page` test too.
Copy link
Contributor

github-actions bot commented Nov 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6eb0af) 68.77% compared to head (6668c47) 68.77%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21639   +/-   ##
========================================
  Coverage    68.77%   68.77%           
========================================
  Files         1037     1037           
  Lines        41290    41290           
  Branches     11025    11025           
========================================
  Hits         28395    28395           
  Misses       12895    12895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronfigueiredo pedronfigueiredo merged commit 1754b3d into develop Nov 1, 2023
14 of 15 checks passed
@pedronfigueiredo pedronfigueiredo deleted the fix/improve-1155-test branch November 1, 2023 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [6668c47]
Page Load Metrics (1156 ± 379 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84124100126
domContentLoaded6911992136
load8120311156789379
domInteractive6911992136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants