Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeFiCh/ain:1.7.x RPCs implementation #202

Closed
30 tasks done
fuxingloh opened this issue May 10, 2021 · 4 comments · Fixed by #581
Closed
30 tasks done

DeFiCh/ain:1.7.x RPCs implementation #202

fuxingloh opened this issue May 10, 2021 · 4 comments · Fixed by #581
Assignees
Labels
area/packages kind/feature New feature request sig/blockchain triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented May 10, 2021

Similar to #48 This tracks all the RPC methods and categories being implemented in jellyfish-api-core. Please tag update this if you want to work on a feature.

As a final docker build is not produced please use the latest 1.7.x docker build for your testcontainers, #184 for more information.

src/masternodes/

rpc_icxorderbook.cpp

rpc_oracles.cpp

src/spv

spv_rpc.cpp

@fuxingloh fuxingloh added kind/feature New feature request triage/accepted Triage has been accepted area/jellyfish-api-core labels May 10, 2021
@fuxingloh fuxingloh changed the title DeFiCh/ain:1.7.x RPC implementation DeFiCh/ain:1.7.x RPCs implementation May 10, 2021
@monstrobishi monstrobishi self-assigned this May 17, 2021
@surangap

This comment has been minimized.

@jingyi2811
Copy link
Contributor

Once the pagination feature is added to the C++ code, I need to open back the merged tickets and add test unit accordingly too

@Jouzo
Copy link
Contributor

Jouzo commented Aug 19, 2021

Reopened to handle DeFiCh/ain#686

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Dec 16, 2021
@defichain-bot defichain-bot removed the needs/area Needs area label(s) label Dec 22, 2021
eli-lim pushed a commit that referenced this issue Mar 27, 2022
* fix

* wip

* add poolpair.service

* added price ratio and totalLiqudityUsd

* add poolpair get service test

* revert config

* revert mapTokenData

* stub testPoolSwap on test

* remove unuse comment

* fix poolpair.test.ts

* fix poolpair.e2e, refine PoolPairData

* use static address for testpoolswap

* get usdtdfi conv price by getpoolpair, remove testpoolswap

* remove log

* tight logic on checking poolpair token id

* added DFI-token poolpair test

* prchanges: rename tokenA/tokenB to ab

* pr changes: remove mock, use created fixture

* refactor poolpair.service.ts to sync instead of live fetching

Co-authored-by: Fuxing Loh <[email protected]>
@cwkang1998
Copy link
Contributor

@fuxingloh Closing this as its completed. If there's any new addition please do reopen it.

canonbrother added a commit that referenced this issue Jun 1, 2022
* fix

* wip

* add poolpair.service

* added price ratio and totalLiqudityUsd

* add poolpair get service test

* revert config

* revert mapTokenData

* stub testPoolSwap on test

* remove unuse comment

* fix poolpair.test.ts

* fix poolpair.e2e, refine PoolPairData

* use static address for testpoolswap

* get usdtdfi conv price by getpoolpair, remove testpoolswap

* remove log

* tight logic on checking poolpair token id

* added DFI-token poolpair test

* prchanges: rename tokenA/tokenB to ab

* pr changes: remove mock, use created fixture

* refactor poolpair.service.ts to sync instead of live fetching

Co-authored-by: Fuxing Loh <[email protected]>
canonbrother added a commit that referenced this issue Jun 1, 2022
* fix

* wip

* add poolpair.service

* added price ratio and totalLiqudityUsd

* add poolpair get service test

* revert config

* revert mapTokenData

* stub testPoolSwap on test

* remove unuse comment

* fix poolpair.test.ts

* fix poolpair.e2e, refine PoolPairData

* use static address for testpoolswap

* get usdtdfi conv price by getpoolpair, remove testpoolswap

* remove log

* tight logic on checking poolpair token id

* added DFI-token poolpair test

* prchanges: rename tokenA/tokenB to ab

* pr changes: remove mock, use created fixture

* refactor poolpair.service.ts to sync instead of live fetching

Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/feature New feature request sig/blockchain triage/accepted Triage has been accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants