Interface icx_listorders RPC
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surangap
requested review from
canonbrother,
fuxingloh,
jingyi2811,
monstrobishi and
thedoublejay
as code owners
canonbrother
requested changes
Jun 23, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/listOrders.test.ts
Outdated
Show resolved
Hide resolved
surangap
force-pushed
the
surangap/icx-getorder
branch
from
cd8d2c5 to
3c57adb
Compare
surangap
force-pushed
the
surangap/icx-listorders
branch
from
440bb01 to
b9a0805
Compare
30 tasks
surangap
force-pushed
the
surangap/icx-getorder
branch
from
3c57adb to
7f3c9eb
Compare
surangap
force-pushed
the
surangap/icx-getorder
branch
from
7f3c9eb to
40f7070
Compare
surangap
force-pushed
the
surangap/icx-listorders
branch
from
b9a0805 to
a698813
Compare
|
Code Climate has analyzed commit c7e11ac and detected 0 issues on this pull request. View more on Code Climate. |
|
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: c7e11ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60dee6daa5901300077c4c7a 😎 Browse the preview: https://deploy-preview-402--jellyfish-defi.netlify.app |
surangap
commented
Jul 1, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/listOrders.test.ts
Show resolved
Hide resolved
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 97.34% 97.36% +0.01%
==========================================
Files 96 96
Lines 2826 2841 +15
Branches 285 285
==========================================
+ Hits 2751 2766 +15
Misses 75 75
Continue to review full report at Codecov.
|
fuxingloh
suggested changes
Jul 1, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/listOrders.test.ts
Outdated
Show resolved
Hide resolved
surangap
force-pushed
the
surangap/icx-listorders
branch
from
f43bb2d to
623f054
Compare
surangap
commented
Jul 2, 2021
| @@ -81,6 +81,59 @@ describe('ICXOrderBook.closeOffer', () => { | |||
| expect(accountBTCAfterOfferClose).toStrictEqual(accountBTCBeforeOffer) | |||
| }) | |||
|
|
|||
| // NOTE(surangap): This test is failing. | |||
There was a problem hiding this comment.
Mihailo is looking into this
surangap
force-pushed
the
surangap/icx-listorders
branch
from
623f054 to
64723ac
Compare
fuxingloh
suggested changes
Jul 2, 2021
packages/jellyfish-api-core/__tests__/category/icxorderbook/icx_setup.ts
Outdated
Show resolved
Hide resolved
surangap
force-pushed
the
surangap/icx-listorders
branch
from
64723ac to
c7e11ac
Compare
fuxingloh
approved these changes
Jul 2, 2021
jingyi2811
approved these changes
Jul 2, 2021
canonbrother
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Bump @defichain/jellyfish dependencies * fixed package-lock.json Co-authored-by: Fuxing Loh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This PR will interface
icx_listordersRPC to jellyfishWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
depends on #401